From: Jakub Kicinski <kuba@kernel.org>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Magnus Karlsson <magnus.karlsson@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Simon Horman <simon.horman@corigine.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
John Fastabend <john.fastabend@gmail.com>,
Aleksander Lobakin <aleksander.lobakin@intel.com>
Subject: Re: [PATCH bpf-next] net, xdp: allow metadata > 32
Date: Fri, 27 Oct 2023 13:09:30 -0700 [thread overview]
Message-ID: <20231027130930.7d6014df@kernel.org> (raw)
In-Reply-To: <20231026165701.65878-1-larysa.zaremba@intel.com>
On Thu, 26 Oct 2023 18:56:59 +0200 Larysa Zaremba wrote:
> static inline bool xdp_metalen_invalid(unsigned long metalen)
> {
> - return (metalen & (sizeof(__u32) - 1)) || (metalen > 32);
> + typeof(metalen) meta_max;
The use of typeof() looks a bit unnecessary..
next prev parent reply other threads:[~2023-10-27 20:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 16:56 [PATCH bpf-next] net, xdp: allow metadata > 32 Larysa Zaremba
2023-10-27 20:09 ` Jakub Kicinski [this message]
2023-10-31 9:39 ` Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027130930.7d6014df@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=larysa.zaremba@intel.com \
--cc=linyunsheng@huawei.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).