* [PATCH net-next] Use xdp_set_features_flag instead of direct assignment
@ 2023-10-27 18:06 Haiyang Zhang
2023-10-27 22:40 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Haiyang Zhang @ 2023-10-27 18:06 UTC (permalink / raw)
To: linux-hyperv, netdev
Cc: haiyangz, decui, stephen, kys, paulros, olaf, vkuznets, davem,
wei.liu, edumazet, kuba, pabeni, leon, longli, ssengar,
linux-rdma, daniel, john.fastabend, bpf, ast, sharmaajay, hawk,
tglx, shradhagupta, linux-kernel, Konstantin Taranov
From: Konstantin Taranov <kotaranov@microsoft.com>
This patch uses a helper function for assignment of xdp_features.
This change simplifies backports.
Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 48ea4aeeea5d..035f24764ad9 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2687,8 +2687,8 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
ndev->features = ndev->hw_features | NETIF_F_HW_VLAN_CTAG_TX |
NETIF_F_HW_VLAN_CTAG_RX;
ndev->vlan_features = ndev->features;
- ndev->xdp_features = NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
- NETDEV_XDP_ACT_NDO_XMIT;
+ xdp_set_features_flag(ndev, NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_REDIRECT |
+ NETDEV_XDP_ACT_NDO_XMIT);
err = register_netdev(ndev);
if (err) {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] Use xdp_set_features_flag instead of direct assignment
2023-10-27 18:06 [PATCH net-next] Use xdp_set_features_flag instead of direct assignment Haiyang Zhang
@ 2023-10-27 22:40 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-10-27 22:40 UTC (permalink / raw)
To: Haiyang Zhang
Cc: linux-hyperv, netdev, decui, stephen, kys, paulros, olaf,
vkuznets, davem, wei.liu, edumazet, pabeni, leon, longli, ssengar,
linux-rdma, daniel, john.fastabend, bpf, ast, sharmaajay, hawk,
tglx, shradhagupta, linux-kernel, Konstantin Taranov
On Fri, 27 Oct 2023 11:06:51 -0700 Haiyang Zhang wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
>
> This patch uses a helper function for assignment of xdp_features.
> This change simplifies backports.
Generally making backports is not a strong enough reason to change
upstream code, but using the helper seems like a good idea.
I touched up the white space and title when applying, thanks!
--
pw-bot: applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-27 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-27 18:06 [PATCH net-next] Use xdp_set_features_flag instead of direct assignment Haiyang Zhang
2023-10-27 22:40 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).