From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>,
dccp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com
Subject: [PATCH net] dccp: check for ccid in ccid_hc_tx_send_packet
Date: Sat, 28 Oct 2023 20:11:36 +0530 [thread overview]
Message-ID: <20231028144136.3462-1-bragathemanick0908@gmail.com> (raw)
ccid_hc_tx_send_packet might be called with a NULL ccid pointer
leading to a NULL pointer dereference
Below mentioned commit has similarly changes
commit 276bdb82dedb ("dccp: check ccid before dereferencing")
Reported-by: syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=c71bc336c5061153b502
Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
---
net/dccp/ccid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dccp/ccid.h b/net/dccp/ccid.h
index 105f3734dadb..1015dc2b9392 100644
--- a/net/dccp/ccid.h
+++ b/net/dccp/ccid.h
@@ -163,7 +163,7 @@ static inline int ccid_packet_dequeue_eval(const int return_code)
static inline int ccid_hc_tx_send_packet(struct ccid *ccid, struct sock *sk,
struct sk_buff *skb)
{
- if (ccid->ccid_ops->ccid_hc_tx_send_packet != NULL)
+ if (ccid != NULL && ccid->ccid_ops->ccid_hc_tx_send_packet != NULL)
return ccid->ccid_ops->ccid_hc_tx_send_packet(sk, skb);
return CCID_PACKET_SEND_AT_ONCE;
}
--
2.34.1
next reply other threads:[~2023-10-28 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 14:41 Bragatheswaran Manickavel [this message]
2023-10-30 8:59 ` [PATCH net] dccp: check for ccid in ccid_hc_tx_send_packet Eric Dumazet
2023-10-30 15:40 ` Bragatheswaran Manickavel
2023-10-30 15:49 ` Eric Dumazet
[not found] ` <4fffeb15-52b1-4f2c-93bb-c3988ddfbf43@gmail.com>
2023-10-30 16:24 ` Eric Dumazet
2023-11-02 11:14 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028144136.3462-1-bragathemanick0908@gmail.com \
--to=bragathemanick0908@gmail.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+c71bc336c5061153b502@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox