* [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
@ 2023-10-30 20:50 Patrick Thompson
2023-10-30 21:44 ` Jacob Keller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Patrick Thompson @ 2023-10-30 20:50 UTC (permalink / raw)
To: netdev
Cc: Patrick Thompson, Chun-Hao Lin, David S. Miller, Eric Dumazet,
Heiner Kallweit, Jakub Kicinski, Paolo Abeni, linux-kernel,
nic_swsd
RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
eapol packets unless allmulti is enabled. These devices correspond to
RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
in the same way that VER_35 has an exception.
Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
Signed-off-by: Patrick Thompson <ptf@google.com>
---
Changes in v3:
- disable mc filter for VER_48
- update description
Changes in v2:
- add Fixes tag
- add net annotation
- update description
drivers/net/ethernet/realtek/r8169_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 361b90007148b..c92286926a1b5 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2584,7 +2584,9 @@ static void rtl_set_rx_mode(struct net_device *dev)
rx_mode |= AcceptAllPhys;
} else if (netdev_mc_count(dev) > MC_FILTER_LIMIT ||
dev->flags & IFF_ALLMULTI ||
- tp->mac_version == RTL_GIGA_MAC_VER_35) {
+ tp->mac_version == RTL_GIGA_MAC_VER_35 ||
+ tp->mac_version == RTL_GIGA_MAC_VER_46 ||
+ tp->mac_version == RTL_GIGA_MAC_VER_48) {
/* accept all multicasts */
} else if (netdev_mc_empty(dev)) {
rx_mode &= ~AcceptMulticast;
--
2.42.0.820.g83a721a137-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
2023-10-30 20:50 [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E Patrick Thompson
@ 2023-10-30 21:44 ` Jacob Keller
2023-10-30 22:02 ` Heiner Kallweit
2023-11-02 12:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jacob Keller @ 2023-10-30 21:44 UTC (permalink / raw)
To: Patrick Thompson, netdev
Cc: Chun-Hao Lin, David S. Miller, Eric Dumazet, Heiner Kallweit,
Jakub Kicinski, Paolo Abeni, linux-kernel, nic_swsd
On 10/30/2023 1:50 PM, Patrick Thompson wrote:
> RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
> eapol packets unless allmulti is enabled. These devices correspond to
> RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
> in the same way that VER_35 has an exception.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@google.com>
> ---
>
> Changes in v3:
> - disable mc filter for VER_48
> - update description
>
> Changes in v2:
> - add Fixes tag
> - add net annotation
> - update description
>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
2023-10-30 20:50 [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E Patrick Thompson
2023-10-30 21:44 ` Jacob Keller
@ 2023-10-30 22:02 ` Heiner Kallweit
2023-11-02 12:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Heiner Kallweit @ 2023-10-30 22:02 UTC (permalink / raw)
To: Patrick Thompson, netdev
Cc: Chun-Hao Lin, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-kernel, nic_swsd
On 30.10.2023 21:50, Patrick Thompson wrote:
> RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
> eapol packets unless allmulti is enabled. These devices correspond to
> RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
> in the same way that VER_35 has an exception.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@google.com>
> ---
>
> Changes in v3:
> - disable mc filter for VER_48
> - update description
>
> Changes in v2:
> - add Fixes tag
> - add net annotation
> - update description
>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
2023-10-30 20:50 [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E Patrick Thompson
2023-10-30 21:44 ` Jacob Keller
2023-10-30 22:02 ` Heiner Kallweit
@ 2023-11-02 12:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-02 12:30 UTC (permalink / raw)
To: Patrick Thompson
Cc: netdev, hau, davem, edumazet, hkallweit1, kuba, pabeni,
linux-kernel, nic_swsd
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 30 Oct 2023 16:50:14 -0400 you wrote:
> RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
> eapol packets unless allmulti is enabled. These devices correspond to
> RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
> in the same way that VER_35 has an exception.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@google.com>
>
> [...]
Here is the summary with links:
- [v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E
https://git.kernel.org/netdev/net/c/efa5f1311c49
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-02 12:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 20:50 [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and RTL8107E Patrick Thompson
2023-10-30 21:44 ` Jacob Keller
2023-10-30 22:02 ` Heiner Kallweit
2023-11-02 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).