From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Jakub Kicinski <kuba@kernel.org>,
Wander Lairson Costa <wander@redhat.com>,
juri.lelli@redhat.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Come On Now <hawk@kernel.org>
Subject: Re: [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional).
Date: Tue, 31 Oct 2023 11:14:24 +0100 [thread overview]
Message-ID: <20231031101424.I2hTisNY@linutronix.de> (raw)
In-Reply-To: <20231016145337.4ZIt_sqL@linutronix.de>
On 2023-10-16 16:53:39 [+0200], To Jakub Kicinski wrote:
> On 2023-10-16 07:17:56 [-0700], Jakub Kicinski wrote:
> > On Mon, 16 Oct 2023 11:53:21 +0200 Sebastian Andrzej Siewior wrote:
> > > > Do we have reason to believe nobody uses RPS?
> > >
> > > Not sure what you relate to. I would assume that RPS is used in general
> > > on actual devices and not on loopback where backlog is used. But it is
> > > just an assumption.
> > > The performance drop, which I observed with RPS and stress-ng --udp, is
> > > within the same range with threads and IPIs (based on memory). I can
> > > re-run the test and provide actual numbers if you want.
> >
> > I was asking about RPS because with your current series RPS processing
> > is forced into threads. IDK how well you can simulate the kind of
> > workload which requires RPS. I've seen it used mostly on proxyies
> > and gateways. For proxies Meta's experiments with threaded NAPI show
> > regressions across the board. So "force-threading" RPS will most likely
> > also cause regressions.
>
> Understood.
>
> Wandere/ Juri: Do you have any benchmark/ workload where you would see
> whether RPS with IPI (now) vs RPS (this patch) shows any regression?
So I poked offlist other RH people and I've been told that they hardly
ever test RPS since the NICs these days have RSS in hardware.
Sebastian
next prev parent reply other threads:[~2023-10-31 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 16:20 [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional) Sebastian Andrzej Siewior
2023-09-29 16:20 ` [PATCH net-next 1/2] net: Use SMP threads for backlog NAPI Sebastian Andrzej Siewior
2023-09-29 16:20 ` [PATCH net-next 2/2] net: Allow to use " Sebastian Andrzej Siewior
2023-10-04 22:46 ` [PATCH net-next 0/2] net: Use SMP threads for backlog NAPI (or optional) Jakub Kicinski
2023-10-07 15:59 ` Sebastian Andrzej Siewior
2023-10-10 1:09 ` Jakub Kicinski
2023-10-16 9:53 ` Sebastian Andrzej Siewior
2023-10-16 14:17 ` Jakub Kicinski
2023-10-16 14:53 ` Sebastian Andrzej Siewior
2023-10-31 10:14 ` Sebastian Andrzej Siewior [this message]
2023-10-31 11:36 ` Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031101424.I2hTisNY@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).