From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Ahmed Zaki <ahmed.zaki@intel.com>,
Alexander H Duyck <alexander.duyck@gmail.com>,
mkubecek@suse.cz, andrew@lunn.ch,
willemdebruijn.kernel@gmail.com,
Wojciech Drewek <wojciech.drewek@intel.com>,
corbet@lwn.net, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, jesse.brandeburg@intel.com,
edumazet@google.com, anthony.l.nguyen@intel.com,
horms@kernel.org, vladimir.oltean@nxp.com,
Jacob Keller <jacob.e.keller@intel.com>,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type
Date: Tue, 31 Oct 2023 12:57:37 -0700 [thread overview]
Message-ID: <20231031125737.0d9a648e@kernel.org> (raw)
In-Reply-To: <ff81c4e7-0787-4357-bb92-9da334a4ddaf@nvidia.com>
On Tue, 31 Oct 2023 18:13:20 +0200 Gal Pressman wrote:
> Sure, IIUC, ice's implementation does a:
> (SRC_IP ^ DST_IP, SRC_IP ^ DST_IP, SRC_PORT ^ DST_PORT, SRC_PORT ^ DST_PORT)
>
> Our implementation isn't exactly xor, it is:
> (SRC_IP | DST_IP, SRC_IP ^ DST_IP, SRC_PORT | DST_PORT, SRC_PORT ^ DST_PORT)
>
> The way I see it, the xor implementation should be clearly documented,
> so no one uses the same flag with a different implementation by mistake.
Got it, thanks!
next prev parent reply other threads:[~2023-10-31 19:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 15:49 [PATCH net-next v4 0/6] Support symmetric RSS (Toeplitz) hash Ahmed Zaki
2023-10-16 15:49 ` [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type Ahmed Zaki
2023-10-16 20:17 ` Alexander H Duyck
2023-10-16 21:08 ` Ahmed Zaki
2023-10-16 22:15 ` Alexander Duyck
2023-10-16 22:44 ` Ahmed Zaki
2023-10-16 22:55 ` Alexander Duyck
2023-10-16 23:30 ` Jakub Kicinski
2023-10-17 0:08 ` Ahmed Zaki
2023-10-17 18:42 ` Alexander Duyck
2023-10-17 19:14 ` Ahmed Zaki
2023-10-17 20:03 ` Alexander Duyck
2023-10-17 20:19 ` Jakub Kicinski
2023-10-17 20:28 ` Alexander Duyck
2023-10-17 18:37 ` Alexander Duyck
2023-10-17 20:17 ` Jakub Kicinski
2023-10-17 20:41 ` Alexander Duyck
2023-10-17 22:12 ` [Intel-wired-lan] " Ahmed Zaki
2023-10-18 0:34 ` Jakub Kicinski
2023-10-18 18:12 ` Alexander Duyck
2023-10-18 23:50 ` Jakub Kicinski
2023-10-20 21:24 ` Ahmed Zaki
2023-10-20 22:33 ` Jakub Kicinski
2023-10-20 23:14 ` [Intel-wired-lan] " Ahmed Zaki
2023-10-20 23:49 ` Jakub Kicinski
2023-10-21 0:00 ` Ahmed Zaki
2023-10-29 12:25 ` Gal Pressman
2023-10-29 12:42 ` Ahmed Zaki
2023-10-29 12:48 ` Gal Pressman
2023-10-29 16:59 ` Ahmed Zaki
2023-10-31 12:00 ` Gal Pressman
2023-10-31 14:40 ` Ahmed Zaki
2023-10-31 14:45 ` Gal Pressman
2023-10-31 15:14 ` Ahmed Zaki
2023-10-31 15:20 ` Jakub Kicinski
2023-10-31 16:13 ` Gal Pressman
2023-10-31 19:57 ` Jakub Kicinski [this message]
2023-10-31 16:12 ` Gal Pressman
2023-10-31 14:59 ` Alexander Duyck
2023-10-31 16:11 ` Gal Pressman
2023-10-16 15:49 ` [PATCH net-next v4 2/6] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-10-16 15:49 ` [PATCH net-next v4 3/6] ice: refactor RSS configuration Ahmed Zaki
2023-10-16 15:49 ` [PATCH net-next v4 4/6] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-10-16 15:49 ` [PATCH net-next v4 5/6] ice: enable symmetric RSS Toeplitz hash for any flow type Ahmed Zaki
2023-10-16 15:49 ` [PATCH net-next v4 6/6] iavf: enable symmetric RSS Toeplitz hash Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031125737.0d9a648e@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).