* [PATCH net] net/smc: fix documentation of buffer sizes
@ 2023-10-30 17:03 Gerd Bayer
2023-11-01 1:07 ` Dust Li
2023-11-02 12:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Gerd Bayer @ 2023-10-30 17:03 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jonathan Corbet
Cc: Jan Karcher, Gerd Bayer, Wenjia Zhang, Tony Lu, netdev, linux-doc,
linux-kernel
Since commit 833bac7ec392 ("net/smc: Fix setsockopt and sysctl to
specify same buffer size again") the SMC protocol uses its own
default values for the smc.rmem and smc.wmem sysctl variables
which are no longer derived from the TCP IPv4 buffer sizes.
Fixup the kernel documentation to reflect this change, too.
Fixes: 833bac7ec392 ("net/smc: Fix setsockopt and sysctl to specify same buffer size again")
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
---
Documentation/networking/smc-sysctl.rst | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
index 6d8acdbe9be1..769149d98773 100644
--- a/Documentation/networking/smc-sysctl.rst
+++ b/Documentation/networking/smc-sysctl.rst
@@ -44,18 +44,16 @@ smcr_testlink_time - INTEGER
wmem - INTEGER
Initial size of send buffer used by SMC sockets.
- The default value inherits from net.ipv4.tcp_wmem[1].
The minimum value is 16KiB and there is no hard limit for max value, but
only allowed 512KiB for SMC-R and 1MiB for SMC-D.
- Default: 16K
+ Default: 64KiB
rmem - INTEGER
Initial size of receive buffer (RMB) used by SMC sockets.
- The default value inherits from net.ipv4.tcp_rmem[1].
The minimum value is 16KiB and there is no hard limit for max value, but
only allowed 512KiB for SMC-R and 1MiB for SMC-D.
- Default: 128K
+ Default: 64KiB
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net/smc: fix documentation of buffer sizes
2023-10-30 17:03 [PATCH net] net/smc: fix documentation of buffer sizes Gerd Bayer
@ 2023-11-01 1:07 ` Dust Li
2023-11-02 12:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Dust Li @ 2023-11-01 1:07 UTC (permalink / raw)
To: Gerd Bayer, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Jonathan Corbet
Cc: Jan Karcher, Wenjia Zhang, Tony Lu, netdev, linux-doc,
linux-kernel
On Mon, Oct 30, 2023 at 06:03:43PM +0100, Gerd Bayer wrote:
>Since commit 833bac7ec392 ("net/smc: Fix setsockopt and sysctl to
>specify same buffer size again") the SMC protocol uses its own
>default values for the smc.rmem and smc.wmem sysctl variables
>which are no longer derived from the TCP IPv4 buffer sizes.
>
>Fixup the kernel documentation to reflect this change, too.
>
>Fixes: 833bac7ec392 ("net/smc: Fix setsockopt and sysctl to specify same buffer size again")
>Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
>Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
>---
> Documentation/networking/smc-sysctl.rst | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/Documentation/networking/smc-sysctl.rst b/Documentation/networking/smc-sysctl.rst
>index 6d8acdbe9be1..769149d98773 100644
>--- a/Documentation/networking/smc-sysctl.rst
>+++ b/Documentation/networking/smc-sysctl.rst
>@@ -44,18 +44,16 @@ smcr_testlink_time - INTEGER
>
> wmem - INTEGER
> Initial size of send buffer used by SMC sockets.
>- The default value inherits from net.ipv4.tcp_wmem[1].
>
> The minimum value is 16KiB and there is no hard limit for max value, but
> only allowed 512KiB for SMC-R and 1MiB for SMC-D.
>
>- Default: 16K
>+ Default: 64KiB
>
> rmem - INTEGER
> Initial size of receive buffer (RMB) used by SMC sockets.
>- The default value inherits from net.ipv4.tcp_rmem[1].
>
> The minimum value is 16KiB and there is no hard limit for max value, but
> only allowed 512KiB for SMC-R and 1MiB for SMC-D.
>
>- Default: 128K
>+ Default: 64KiB
>--
>2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net/smc: fix documentation of buffer sizes
2023-10-30 17:03 [PATCH net] net/smc: fix documentation of buffer sizes Gerd Bayer
2023-11-01 1:07 ` Dust Li
@ 2023-11-02 12:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-02 12:00 UTC (permalink / raw)
To: Gerd Bayer
Cc: davem, edumazet, kuba, pabeni, corbet, jaka, wenjia, tonylu,
netdev, linux-doc, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 30 Oct 2023 18:03:43 +0100 you wrote:
> Since commit 833bac7ec392 ("net/smc: Fix setsockopt and sysctl to
> specify same buffer size again") the SMC protocol uses its own
> default values for the smc.rmem and smc.wmem sysctl variables
> which are no longer derived from the TCP IPv4 buffer sizes.
>
> Fixup the kernel documentation to reflect this change, too.
>
> [...]
Here is the summary with links:
- [net] net/smc: fix documentation of buffer sizes
https://git.kernel.org/netdev/net/c/a1602d749097
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-02 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 17:03 [PATCH net] net/smc: fix documentation of buffer sizes Gerd Bayer
2023-11-01 1:07 ` Dust Li
2023-11-02 12:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).