[PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[Jakub Kicinski]

W=1 builds now warn if a module is built without
a MODULE_DESCRIPTION(). Fill it in for sock_diag.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/netlink/diag.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netlink/diag.c b/net/netlink/diag.c
index 9c4f231be275..1eeff9422856 100644
--- a/net/netlink/diag.c
+++ b/net/netlink/diag.c
@@ -257,5 +257,6 @@ static void __exit netlink_diag_exit(void)
 
 module_init(netlink_diag_init);
 module_exit(netlink_diag_exit);
+MODULE_DESCRIPTION("Netlink-based socket monitoring/diagnostic interface (sock_diag)");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_NET_PF_PROTO_TYPE(PF_NETLINK, NETLINK_SOCK_DIAG, 16 /* AF_NETLINK */);
-- 
2.41.0

Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[Jiri Pirko]

Thu, Nov 02, 2023 at 05:57:24AM CET, kuba@kernel.org wrote:
>W=1 builds now warn if a module is built without
>a MODULE_DESCRIPTION(). Fill it in for sock_diag.
>
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>

It's a bit odd to target -net with this, isn't it?

Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[Florian Westphal]

Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Nov 02, 2023 at 05:57:24AM CET, kuba@kernel.org wrote:
> >W=1 builds now warn if a module is built without
> >a MODULE_DESCRIPTION(). Fill it in for sock_diag.
> >
> >Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> It's a bit odd to target -net with this, isn't it?

I had planned to fill the missing descriptions for
all netfilter via next nf.git PR as I consider those as
bug fixes.

Thats the regression risk here?

Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[Jakub Kicinski]

On Thu, 2 Nov 2023 13:05:33 +0100 Florian Westphal wrote:
> > It's a bit odd to target -net with this, isn't it?  

I mostly wanted to make sure the build bot still works after
we sucked in all the code from Linus. There was no patches getting
posted but...

> I had planned to fill the missing descriptions for
> all netfilter via next nf.git PR as I consider those as
> bug fixes.
> 
> Thats the regression risk here?

+1 for getting it into net, no regression risk and it's low key
annoying to see all these warnings.

Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed,  1 Nov 2023 21:57:24 -0700 you wrote:
> W=1 builds now warn if a module is built without
> a MODULE_DESCRIPTION(). Fill it in for sock_diag.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  net/netlink/diag.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [net] netlink: fill in missing MODULE_DESCRIPTION()
    https://git.kernel.org/netdev/net/c/016b9332a334

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html