From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size
Date: Thu, 2 Nov 2023 12:48:13 +0200 [thread overview]
Message-ID: <20231102104813.qyzkfpbwz4kiloez@skbuf> (raw)
In-Reply-To: <CACRpkdYb6v6dpFFySSHdQ0H+KYRDNr2V4ShZTVA2A0ar_h9D=A@mail.gmail.com> <CACRpkdYb6v6dpFFySSHdQ0H+KYRDNr2V4ShZTVA2A0ar_h9D=A@mail.gmail.com>
On Tue, Oct 31, 2023 at 10:22:05PM +0100, Linus Walleij wrote:
> Hi Vladimir,
>
> I got around to testing this too:
>
> # ping -s 1472 192.168.1.137
>
> The result:
>
> SKB before padding:
> 37 (192.168.1.13skb len=1514 headroom=18 headlen=1514 tailroom=260
> mac=(18,14) net=(32,20) trans=52
> shinfo(txflags=0 nr_frags=0 gso(size=0 type=0 segs=0))
> csum(0xd4ef2b1 ip_summed=0 complete_sw=0 valid=0 level=0)
> hash(0x0 sw=0 l4=0) proto=0x0800 pkttype=0 iif=0
> 7): 1472 data bydev name=lan0 feat=0x0002000000005020
> tes
> sk family=2 type=3 proto=1
>
> SKB after padding:
> skb len=1518 headroom=18 headlen=1518 tailroom=256
> mac=(18,14) net=(32,20) trans=52
> shinfo(txflags=0 nr_frags=0 gso(size=0 type=0 segs=0))
> csum(0xd4ef2b1 ip_summed=0 complete_sw=0 valid=0 level=0)
> hash(0x0 sw=0 l4=0) proto=0x0800 pkttype=0 iif=0
> dev name=lan0 feat=0x0002000000005020
> sk family=2 type=3 proto=1
>
> As expected the linear SKB is 4 bytes longer in this case.
Ok, I'm not seeing anything unusual about the skb geometry in the
skb_dump() output.
next prev parent reply other threads:[~2023-11-02 10:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 9:26 [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size Linus Walleij
2023-10-30 14:16 ` Vladimir Oltean
2023-10-30 14:37 ` Linus Walleij
2023-10-30 15:23 ` Vladimir Oltean
2023-10-30 15:30 ` Vladimir Oltean
2023-10-31 21:22 ` Linus Walleij
2023-11-02 10:48 ` Vladimir Oltean [this message]
2023-10-30 21:50 ` Linus Walleij
2023-10-30 22:20 ` Vladimir Oltean
2023-10-30 22:57 ` Linus Walleij
2023-10-30 23:09 ` Vladimir Oltean
2023-10-30 23:11 ` Linus Walleij
2023-10-31 0:37 ` Andrew Lunn
2023-10-31 3:37 ` Florian Fainelli
2023-10-31 14:06 ` Linus Walleij
2023-10-31 16:23 ` Florian Fainelli
2023-10-30 23:33 ` Vladimir Oltean
2023-10-31 14:16 ` Linus Walleij
2023-10-31 16:34 ` Vladimir Oltean
2023-10-31 19:02 ` Linus Walleij
2023-11-02 12:32 ` Vladimir Oltean
2023-10-31 19:18 ` Luiz Angelo Daros de Luca
2023-10-31 19:27 ` Linus Walleij
2023-11-01 12:35 ` Luiz Angelo Daros de Luca
2023-11-01 20:26 ` Linus Walleij
2023-11-02 10:04 ` Vladimir Oltean
2023-11-02 10:45 ` Vladimir Oltean
2023-11-03 17:05 ` Luiz Angelo Daros de Luca
2023-12-30 5:19 ` Luiz Angelo Daros de Luca
2023-12-30 12:28 ` Linus Walleij
2023-12-30 23:56 ` Luiz Angelo Daros de Luca
2023-11-02 10:31 ` Vladimir Oltean
2023-11-03 17:13 ` Luiz Angelo Daros de Luca
2023-10-31 22:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102104813.qyzkfpbwz4kiloez@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox