From: Florian Westphal <fw@strlen.de>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION()
Date: Thu, 2 Nov 2023 13:05:33 +0100 [thread overview]
Message-ID: <20231102120533.GL6174@breakpoint.cc> (raw)
In-Reply-To: <ZUOP7tOSK2ysyuUc@nanopsycho>
Jiri Pirko <jiri@resnulli.us> wrote:
> Thu, Nov 02, 2023 at 05:57:24AM CET, kuba@kernel.org wrote:
> >W=1 builds now warn if a module is built without
> >a MODULE_DESCRIPTION(). Fill it in for sock_diag.
> >
> >Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> It's a bit odd to target -net with this, isn't it?
I had planned to fill the missing descriptions for
all netfilter via next nf.git PR as I consider those as
bug fixes.
Thats the regression risk here?
next prev parent reply other threads:[~2023-11-02 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 4:57 [PATCH net] netlink: fill in missing MODULE_DESCRIPTION() Jakub Kicinski
2023-11-02 12:02 ` Jiri Pirko
2023-11-02 12:05 ` Florian Westphal [this message]
2023-11-02 17:14 ` Jakub Kicinski
2023-11-03 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102120533.GL6174@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).