From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF945179BF for ; Thu, 2 Nov 2023 12:05:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 448EC1BF0 for ; Thu, 2 Nov 2023 05:05:46 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qyWS5-0007MR-WE; Thu, 02 Nov 2023 13:05:34 +0100 Date: Thu, 2 Nov 2023 13:05:33 +0100 From: Florian Westphal To: Jiri Pirko Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com Subject: Re: [PATCH net] netlink: fill in missing MODULE_DESCRIPTION() Message-ID: <20231102120533.GL6174@breakpoint.cc> References: <20231102045724.2516647-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Jiri Pirko wrote: > Thu, Nov 02, 2023 at 05:57:24AM CET, kuba@kernel.org wrote: > >W=1 builds now warn if a module is built without > >a MODULE_DESCRIPTION(). Fill it in for sock_diag. > > > >Signed-off-by: Jakub Kicinski > > It's a bit odd to target -net with this, isn't it? I had planned to fill the missing descriptions for all netfilter via next nf.git PR as I consider those as bug fixes. Thats the regression risk here?