From: Vladimir Oltean <olteanv@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Luiz Angelo Daros de Luca <luizluca@gmail.com>,
netdev@vger.kernel.org, alsi@bang-olufsen.dk, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzk+dt@kernel.org, arinc.unal@arinc9.com
Subject: Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset controller
Date: Thu, 2 Nov 2023 17:57:03 +0200 [thread overview]
Message-ID: <20231102155703.2itwweekjr7uqbsg@skbuf> (raw)
In-Reply-To: <20231102155521.2yo5qpugdhkjy22x@skbuf>
On Thu, Nov 02, 2023 at 05:55:21PM +0200, Vladimir Oltean wrote:
> diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
> index 060165a85fb7..857a039fb0f1 100644
> --- a/drivers/net/dsa/realtek/Kconfig
> +++ b/drivers/net/dsa/realtek/Kconfig
> @@ -15,39 +15,37 @@ menuconfig NET_DSA_REALTEK
>
> if NET_DSA_REALTEK
>
> +config NET_DSA_REALTEK_INTERFACE
> + tristate
> + help
> + Common interface driver for accessing Realtek switches, either
> + through MDIO or SMI.
> +
> config NET_DSA_REALTEK_MDIO
> - tristate "Realtek MDIO interface driver"
> - depends on OF
> - depends on NET_DSA_REALTEK_RTL8365MB || NET_DSA_REALTEK_RTL8366RB
> - depends on NET_DSA_REALTEK_RTL8365MB || !NET_DSA_REALTEK_RTL8365MB
> - depends on NET_DSA_REALTEK_RTL8366RB || !NET_DSA_REALTEK_RTL8366RB
> + tristate "Realtek MDIO interface support"
I meant to also make "config NET_DSA_REALTEK_MDIO" a bool and not tristate.
> help
> Select to enable support for registering switches configured
> through MDIO.
>
> config NET_DSA_REALTEK_SMI
> - tristate "Realtek SMI interface driver"
> - depends on OF
> - depends on NET_DSA_REALTEK_RTL8365MB || NET_DSA_REALTEK_RTL8366RB
> - depends on NET_DSA_REALTEK_RTL8365MB || !NET_DSA_REALTEK_RTL8365MB
> - depends on NET_DSA_REALTEK_RTL8366RB || !NET_DSA_REALTEK_RTL8366RB
> + bool "Realtek SMI interface support"
> help
> Select to enable support for registering switches connected
> through SMI.
>
> config NET_DSA_REALTEK_RTL8365MB
> tristate "Realtek RTL8365MB switch subdriver"
> - imply NET_DSA_REALTEK_SMI
> - imply NET_DSA_REALTEK_MDIO
> + select NET_DSA_REALTEK_INTERFACE
> select NET_DSA_TAG_RTL8_4
> + depends on OF
> help
> Select to enable support for Realtek RTL8365MB-VC and RTL8367S.
>
> config NET_DSA_REALTEK_RTL8366RB
> tristate "Realtek RTL8366RB switch subdriver"
> - imply NET_DSA_REALTEK_SMI
> - imply NET_DSA_REALTEK_MDIO
> + select NET_DSA_REALTEK_INTERFACE
> select NET_DSA_TAG_RTL4_A
> + depends on OF
> help
> Select to enable support for Realtek RTL8366RB.
next prev parent reply other threads:[~2023-11-02 15:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 19:00 [PATCH net-next v2 0/3] net: dsa: realtek: support reset controller Luiz Angelo Daros de Luca
2023-10-27 19:00 ` [PATCH net-next v2 1/3] dt-bindings: net: dsa: realtek: reset-gpios is not required Luiz Angelo Daros de Luca
2023-10-28 7:49 ` Arınç ÜNAL
2023-10-30 17:40 ` Rob Herring
2023-10-27 19:00 ` [PATCH net-next v2 2/3] dt-bindings: net: dsa: realtek: add reset controller Luiz Angelo Daros de Luca
2023-10-28 7:50 ` Arınç ÜNAL
2023-10-30 13:15 ` Rob Herring
2023-10-30 22:30 ` Luiz Angelo Daros de Luca
2023-10-27 19:00 ` [PATCH net-next v2 3/3] net: dsa: realtek: support " Luiz Angelo Daros de Luca
2023-10-27 20:20 ` Andrew Lunn
2023-10-30 20:50 ` Vladimir Oltean
2023-10-31 0:30 ` Luiz Angelo Daros de Luca
2023-11-01 19:55 ` Luiz Angelo Daros de Luca
2023-11-02 14:04 ` Vladimir Oltean
2023-11-02 14:59 ` Linus Walleij
2023-11-02 15:55 ` Vladimir Oltean
2023-11-02 15:57 ` Vladimir Oltean [this message]
2023-11-02 16:21 ` Vladimir Oltean
2023-11-03 17:37 ` Linus Walleij
2023-11-06 22:37 ` Luiz Angelo Daros de Luca
2023-11-07 8:03 ` Linus Walleij
2023-11-07 13:54 ` Luiz Angelo Daros de Luca
2023-11-02 14:13 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102155703.2itwweekjr7uqbsg@skbuf \
--to=olteanv@gmail.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).