* [PATCH iwl-next] i40e: Remove AQ register definitions for VF types
@ 2023-10-26 8:38 Ivan Vecera
2023-10-26 9:17 ` [Intel-wired-lan] " Przemek Kitszel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ivan Vecera @ 2023-10-26 8:38 UTC (permalink / raw)
To: netdev
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, intel-wired-lan, linux-kernel,
Jacob Keller, Wojciech Drewek
The i40e driver does not handle its VF device types so there
is no need to keep AdminQ register definitions for such
device types. Remove them.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
index d561687303ea..2e1eaca44343 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_register.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
@@ -863,16 +863,6 @@
#define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
#define I40E_PFPM_WUFC_MAG_SHIFT 1
#define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
-#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
-#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
-#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
-#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
-#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
-#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
-#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
-#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
-#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
-#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
#define I40E_VFQF_HLUT_MAX_INDEX 15
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Remove AQ register definitions for VF types
2023-10-26 8:38 [PATCH iwl-next] i40e: Remove AQ register definitions for VF types Ivan Vecera
@ 2023-10-26 9:17 ` Przemek Kitszel
2023-10-26 9:51 ` Wojciech Drewek
2023-11-03 17:13 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Przemek Kitszel @ 2023-10-26 9:17 UTC (permalink / raw)
To: Ivan Vecera, netdev
Cc: Wojciech Drewek, intel-wired-lan, Jesse Brandeburg, linux-kernel,
Eric Dumazet, Tony Nguyen, Jacob Keller, Jakub Kicinski,
Paolo Abeni, David S. Miller
On 10/26/23 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
> #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
> #define I40E_PFPM_WUFC_MAG_SHIFT 1
> #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
> #define I40E_VFQF_HLUT_MAX_INDEX 15
>
>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iwl-next] i40e: Remove AQ register definitions for VF types
2023-10-26 8:38 [PATCH iwl-next] i40e: Remove AQ register definitions for VF types Ivan Vecera
2023-10-26 9:17 ` [Intel-wired-lan] " Przemek Kitszel
@ 2023-10-26 9:51 ` Wojciech Drewek
2023-11-03 17:13 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Wojciech Drewek @ 2023-10-26 9:51 UTC (permalink / raw)
To: Ivan Vecera, netdev
Cc: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, intel-wired-lan, linux-kernel,
Jacob Keller
On 26.10.2023 10:38, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
Thanks Ivan!
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> drivers/net/ethernet/intel/i40e/i40e_register.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_register.h b/drivers/net/ethernet/intel/i40e/i40e_register.h
> index d561687303ea..2e1eaca44343 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_register.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_register.h
> @@ -863,16 +863,6 @@
> #define I40E_PFPM_WUFC 0x0006B400 /* Reset: POR */
> #define I40E_PFPM_WUFC_MAG_SHIFT 1
> #define I40E_PFPM_WUFC_MAG_MASK I40E_MASK(0x1, I40E_PFPM_WUFC_MAG_SHIFT)
> -#define I40E_VF_ARQBAH1 0x00006000 /* Reset: EMPR */
> -#define I40E_VF_ARQBAL1 0x00006C00 /* Reset: EMPR */
> -#define I40E_VF_ARQH1 0x00007400 /* Reset: EMPR */
> -#define I40E_VF_ARQLEN1 0x00008000 /* Reset: EMPR */
> -#define I40E_VF_ARQT1 0x00007000 /* Reset: EMPR */
> -#define I40E_VF_ATQBAH1 0x00007800 /* Reset: EMPR */
> -#define I40E_VF_ATQBAL1 0x00007C00 /* Reset: EMPR */
> -#define I40E_VF_ATQH1 0x00006400 /* Reset: EMPR */
> -#define I40E_VF_ATQLEN1 0x00006800 /* Reset: EMPR */
> -#define I40E_VF_ATQT1 0x00008400 /* Reset: EMPR */
> #define I40E_VFQF_HLUT_MAX_INDEX 15
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iwl-next] i40e: Remove AQ register definitions for VF types
2023-10-26 8:38 [PATCH iwl-next] i40e: Remove AQ register definitions for VF types Ivan Vecera
2023-10-26 9:17 ` [Intel-wired-lan] " Przemek Kitszel
2023-10-26 9:51 ` Wojciech Drewek
@ 2023-11-03 17:13 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-11-03 17:13 UTC (permalink / raw)
To: Ivan Vecera
Cc: netdev, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
linux-kernel, Jacob Keller, Wojciech Drewek
On Thu, Oct 26, 2023 at 10:38:22AM +0200, Ivan Vecera wrote:
> The i40e driver does not handle its VF device types so there
> is no need to keep AdminQ register definitions for such
> device types. Remove them.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Thanks, another nice cleanup.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-03 17:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-26 8:38 [PATCH iwl-next] i40e: Remove AQ register definitions for VF types Ivan Vecera
2023-10-26 9:17 ` [Intel-wired-lan] " Przemek Kitszel
2023-10-26 9:51 ` Wojciech Drewek
2023-11-03 17:13 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).