netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: nat: add MODULE_DESCRIPTION
@ 2023-11-04  3:40 Randy Dunlap
  2023-11-04 10:15 ` Florian Westphal
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-11-04  3:40 UTC (permalink / raw)
  To: netdev
  Cc: Randy Dunlap, Pablo Neira Ayuso, Jozsef Kadlecsik,
	Florian Westphal, netfilter-devel, coreteam

Add a MODULE_DESCRIPTION() to iptable_nat.c to avoid a build warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in net/ipv4/netfilter/iptable_nat.o

This is only exposed when using "W=n".

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
---
 net/ipv4/netfilter/iptable_nat.c |    1 +
 1 file changed, 1 insertion(+)

diff -- a/net/ipv4/netfilter/iptable_nat.c b/net/ipv4/netfilter/iptable_nat.c
--- a/net/ipv4/netfilter/iptable_nat.c
+++ b/net/ipv4/netfilter/iptable_nat.c
@@ -169,4 +169,5 @@ static void __exit iptable_nat_exit(void
 module_init(iptable_nat_init);
 module_exit(iptable_nat_exit);
 
+MODULE_DESCRIPTION("Netfilter NAT module");
 MODULE_LICENSE("GPL");

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] netfilter: nat: add MODULE_DESCRIPTION
  2023-11-04  3:40 [PATCH] netfilter: nat: add MODULE_DESCRIPTION Randy Dunlap
@ 2023-11-04 10:15 ` Florian Westphal
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2023-11-04 10:15 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: netdev, Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
	netfilter-devel, coreteam

Randy Dunlap <rdunlap@infradead.org> wrote:
> Add a MODULE_DESCRIPTION() to iptable_nat.c to avoid a build warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in net/ipv4/netfilter/iptable_nat.o
> 
> This is only exposed when using "W=n".

Thanks, but I have just sent a patch to fill all of them,
so I would take that one instead.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-04 10:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-04  3:40 [PATCH] netfilter: nat: add MODULE_DESCRIPTION Randy Dunlap
2023-11-04 10:15 ` Florian Westphal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).