From: Simon Horman <horms@kernel.org>
To: Ronald Wahl <rwahl@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Roger Quadros <rogerq@kernel.org>,
Ronald Wahl <ronald.wahl@raritan.com>
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: rx_pause/tx_pause controls wrong direction
Date: Sat, 4 Nov 2023 12:10:52 -0400 [thread overview]
Message-ID: <20231104161052.GL891380@kernel.org> (raw)
In-Reply-To: <20231031122005.13368-1-rwahl@gmx.de>
On Tue, Oct 31, 2023 at 01:20:05PM +0100, Ronald Wahl wrote:
> From: Ronald Wahl <ronald.wahl@raritan.com>
>
> The rx_pause flag says that whether we support receiving Pause frames.
> When a Pause frame is received TX is delayed for some time. This is TX
> flow control. In the same manner tx_pause is actually RX flow control.
>
> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
Hi Ronald,
I am a little unclear if this patch addresses a user-visible bug, or
is adding a new feature.
If it is fixing a bug then it should be targeted at the net tree.
It should apply cleanly there, and the tree should be noted in the subject.
Subject: [PATCH net] net: ethernet: ...
Also, if it is a bug fix, it should have a fixes tag, indicating the
revision(s) where the problem was introduced. This to assist in backporting
fixes. In this case perhaps the following is appropriate:
Fixes: e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
It is probably not necessary to repost to address the above.
But please keep it in mind for future Networking patches.
On the other hand, if this is a new feature, then it should be targeted
at net-next:
Subject: [PATCH net-next] net: ethernet: ...
And in that case the following applies.
## Form letter - net-next-closed
The merge window for v6.7 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after November 12th.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
prev parent reply other threads:[~2023-11-04 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:20 [PATCH] net: ethernet: ti: am65-cpsw: rx_pause/tx_pause controls wrong direction Ronald Wahl
2023-11-04 16:10 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231104161052.GL891380@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=ronald.wahl@raritan.com \
--cc=rwahl@gmx.de \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).