From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A612C859; Mon, 6 Nov 2023 21:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rXYeTCNV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4821EC433C9; Mon, 6 Nov 2023 21:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699305411; bh=k2iHsevdylVfNnzq7vpSFHrz7HmQmltAVDcN12lB57M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rXYeTCNVWqISuAwfrqkINqGZUcV4qtcxPGdhwjgQXWbySb/hqmbVlZ3jbClBYSZcU Z31DK2I3f59Tkv9EeDg1BGoAw8jf8EOPv+IPNxHcD7X5DSpCwql8fODXsgvOIHSXug uBF0ZvmhqKP8nlLwdZ1Iw1PZdcChZ9Yz+TqjrmnAHfZ6K9W2LFLlF+rz1gxZa7Gz+o erGJBRBZ89WPxVdDsrVDn/c5v9y80iLmnVMz7wDhMkvv+ngMA1R6LfnRJHEeB7Qu87 Bd1KkuoRe1uPJaS7ncTHNi2LxqjkKfOFkp1e9AJLyLz67rvCKdFP5rhfI+WQI/5VV5 P+5LCDGNU27Rg== Date: Mon, 6 Nov 2023 14:16:48 -0700 From: Nathan Chancellor To: Jakub Kicinski Cc: Eric Dumazet , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, ndesaulniers@google.com, trix@redhat.com, 0x7f454c46@gmail.com, noureddine@arista.com, hch@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, patches@lists.linux.dev Subject: Re: [PATCH net v2] tcp: Fix -Wc23-extensions in tcp_options_write() Message-ID: <20231106211648.GA682811@dev-arch.thelio-3990X> References: <20231106-tcp-ao-fix-label-in-compound-statement-warning-v2-1-91eff6e1648c@kernel.org> <20231106155806.GA1181828@dev-arch.thelio-3990X> <20231106125257.43f52b1f@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106125257.43f52b1f@kernel.org> On Mon, Nov 06, 2023 at 12:52:57PM -0800, Jakub Kicinski wrote: > On Mon, 6 Nov 2023 08:58:06 -0700 Nathan Chancellor wrote: > > Ah, this suggestion is much better, thanks. I'll make this adjustment > > and send a v3 later today in case others have any suggested changes (I > > know netdev prefers waiting 24 hours for another revision but I'd like > > to get this warning cleared up by -rc1 so it does not proliferate into > > other trees and I sent v1 almost a week ago). > > Definitely, sorry about the delay, feel free to post v3 ASAP. Done, thanks Jakub! https://lore.kernel.org/20231106-tcp-ao-fix-label-in-compound-statement-warning-v3-1-b54a64602a85@kernel.org/ Cheers, Nathan