From: Simon Horman <horms@kernel.org>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: "Maciej Żenczykowski" <zenczykowski@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Florian Westphal" <fw@strlen.de>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
"Netfilter Development Mailing List"
<netfilter-devel@vger.kernel.org>,
"Jan Engelhardt" <jengelh@inai.de>,
"Patrick McHardy" <kaber@trash.net>
Subject: Re: [PATCH net v2] netfilter: xt_recent: fix (increase) ipv6 literal buffer length
Date: Tue, 7 Nov 2023 12:11:03 -0500 [thread overview]
Message-ID: <20231107171103.GA316877@kernel.org> (raw)
In-Reply-To: <20231105195600.522779-1-maze@google.com>
On Sun, Nov 05, 2023 at 11:56:00AM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <zenczykowski@gmail.com>
>
> in6_pton() supports 'low-32-bit dot-decimal representation'
> (this is useful with DNS64/NAT64 networks for example):
>
> # echo +aaaa:bbbb:cccc:dddd:eeee:ffff:1.2.3.4 > /proc/self/net/xt_recent/DEFAULT
> # cat /proc/self/net/xt_recent/DEFAULT
> src=aaaa:bbbb:cccc:dddd:eeee:ffff:0102:0304 ttl: 0 last_seen: 9733848829 oldest_pkt: 1 9733848829
>
> but the provided buffer is too short:
>
> # echo +aaaa:bbbb:cccc:dddd:eeee:ffff:255.255.255.255 > /proc/self/net/xt_recent/DEFAULT
> -bash: echo: write error: Invalid argument
>
> Cc: Jan Engelhardt <jengelh@inai.de>
> Cc: Patrick McHardy <kaber@trash.net>
> Fixes: 079aa88fe717 ("netfilter: xt_recent: IPv6 support")
> Signed-off-by: Maciej Żenczykowski <zenczykowski@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2023-11-07 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 19:56 [PATCH net v2] netfilter: xt_recent: fix (increase) ipv6 literal buffer length Maciej Żenczykowski
2023-11-07 17:11 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107171103.GA316877@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=kaber@trash.net \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).