From: Jakub Kicinski <kuba@kernel.org>
To: Johnathan Mantey <johnathanx.mantey@intel.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH][ncsi] Revert NCSI link loss/gain commit
Date: Wed, 8 Nov 2023 18:06:12 -0800 [thread overview]
Message-ID: <20231108180602.43c2bfad@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20231108222943.4098887-1-johnathanx.mantey@intel.com>
On Wed, 8 Nov 2023 14:29:43 -0800 Johnathan Mantey wrote:
> The NCSI commit
> ncsi: Propagate carrier gain/loss events to the NCSI controller
> introduced unwanted behavior.
>
> The intent for the commit was to be able to detect carrier loss/gain
> for just the NIC connected to the BMC. The unwanted effect is a
> carrier loss for auxiliary paths also causes the BMC to lose
> carrier. The BMC never regains carrier despite the secondary NIC
> regaining a link.
>
> This change, when merged, needs to be backported to stable kernels.
You need to add a Fixes tag (pointing at the reverted change),
and a CC: stable tag. Here's an example of a well formatted fix:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=02d5fdbf4f2b8c406f7a4c98fa52aa181a11d733
When you repost make sure you use get_maintainers on the patch file,
to catch all reviewers. And put [PATCH net v2] ncsi: Revert...
as the subject.
--
pw-bot: cr
prev parent reply other threads:[~2023-11-09 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 22:29 [PATCH][ncsi] Revert NCSI link loss/gain commit Johnathan Mantey
2023-11-09 2:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108180602.43c2bfad@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=johnathanx.mantey@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox