From: Jakub Kicinski <kuba@kernel.org>
To: longli@linuxonhyperv.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Long Li <longli@microsoft.com>
Subject: Re: [PATCH net-next v4] hv_netvsc: Mark VF as slave before exposing it to user-mode
Date: Wed, 8 Nov 2023 18:13:18 -0800 [thread overview]
Message-ID: <20231108181318.5360af18@kernel.org> (raw)
In-Reply-To: <1699484212-24079-1-git-send-email-longli@linuxonhyperv.com>
On Wed, 8 Nov 2023 14:56:52 -0800 longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> When a VF is being exposed form the kernel, it should be marked as "slave"
> before exposing to the user-mode. The VF is not usable without netvsc running
> as master. The user-mode should never see a VF without the "slave" flag.
>
> An example of a user-mode program depending on this flag is cloud-init
> (https://github.com/canonical/cloud-init/blob/19.3/cloudinit/net/__init__.py)
Quick grep for "flags", "priv" and "slave" doesn't show anything.
Can you point me to the line of code?
> When scanning interfaces, it checks on if this interface has a master to
> decide if it should be configured. There are other user-mode programs perform
> similar checks.
>
> This commit moves the code of setting the slave flag to the time before VF is
> exposed to user-mode.
> Change since v3:
> Change target to net-next.
You don't consider this a fix? It seems like a race condition.
> - if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr)) {
> - netdev_notice(vf_netdev,
> - "falling back to mac addr based matching\n");
> + if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr) ||
> + ether_addr_equal(vf_netdev->dev_addr, ndev->perm_addr))
This change doesn't seem to be described in the commit message.
Please note that we have a rule against reposting patches within 24h:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
next prev parent reply other threads:[~2023-11-09 2:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 22:56 [PATCH net-next v4] hv_netvsc: Mark VF as slave before exposing it to user-mode longli
2023-11-09 2:13 ` Jakub Kicinski [this message]
2023-11-10 0:43 ` Long Li
2023-11-10 20:05 ` Jakub Kicinski
2023-11-15 16:14 ` Stephen Hemminger
2023-11-18 17:38 ` Jakub Kicinski
2023-11-21 0:23 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108181318.5360af18@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).