From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADCC32C88 for ; Wed, 8 Nov 2023 18:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BMxkl6rj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBAB0C433C7; Wed, 8 Nov 2023 18:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699469994; bh=v3G0suFuSmu2T8ydyAp7Qupj+ZJkhevbQT+X0L5Plq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMxkl6rjHtARSgLUKCfaKY7dL8FOPzGBmz08vbvy2tXotYk/YTjDsRtZWpXfV0B7o kmlormRXApzecYV5LVzRXTiuM3osLP7pqrhFrb3LCcGO+zseyLSVhWH3eKx4ady4nO pgpuJS5amOoZLtxw5e8eCW/rdGIOW6pBtTVzlWsGaEDfFuKPQnEQ+lhbvxyyP5nHUq ZA54kJByRrer55129aQMhwDRSTI2bo34d2eH+wFgaWsYYA3Yt2idFrajqrXAcm+w0S v64wEeUaVyPZack2Rv6yRhoBc+Q+rtdUR+KrvoAbuFuFo8ELesymjoYA/tWlwBdWAc v8IgVmMC82YYA== Date: Wed, 8 Nov 2023 13:59:51 -0500 From: Simon Horman To: Paul Greenwalt Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, tony.brelinski@intel.com, Dan Nowlin , Maciej Fijalkowski , Wojciech Drewek , Jacob Keller Subject: Re: [PATCH iwl-net v3] ice: fix DDP package download for packages without signature segment Message-ID: <20231108185951.GE173253@kernel.org> References: <20231107173227.862417-1-paul.greenwalt@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107173227.862417-1-paul.greenwalt@intel.com> On Tue, Nov 07, 2023 at 12:32:27PM -0500, Paul Greenwalt wrote: > From: Dan Nowlin > > Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment") > incorrectly removed support for package download for packages without a > signature segment. These packages include the signature buffer inline > in the configurations buffers, and not in a signature segment. > > Fix package download by providing download support for both packages > with (ice_download_pkg_with_sig_seg()) and without signature segment > (ice_download_pkg_without_sig_seg()). > > Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment") > Reported-by: Maciej Fijalkowski > Closes: https://lore.kernel.org/netdev/ZUT50a94kk2pMGKb@boxer/ > Tested-by: Maciej Fijalkowski > Reviewed-by: Wojciech Drewek > Reviewed-by: Jacob Keller > Signed-off-by: Dan Nowlin > Signed-off-by: Paul Greenwalt Reviewed-by: Simon Horman