From: Jakub Kicinski <kuba@kernel.org>
To: "Dae R. Jeong" <threeearcat@gmail.com>
Cc: borisp@nvidia.com, john.fastabend@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ywchoi@casys.kaist.ac.kr
Subject: Re: [PATCH] tls: fix missing memory barrier in tls_init
Date: Fri, 10 Nov 2023 11:44:10 -0800 [thread overview]
Message-ID: <20231110114410.01cd3eb3@kernel.org> (raw)
In-Reply-To: <ZU4Mk_RfzvRpwkmX@dragonet>
On Fri, 10 Nov 2023 19:57:23 +0900 Dae R. Jeong wrote:
> + mutex_init(&ctx->tx_lock);
> + ctx->sk_proto = READ_ONCE(sk->sk_prot);
> + ctx->sk = sk;
> ctx->tx_conf = TLS_BASE;
> ctx->rx_conf = TLS_BASE;
TLS_BASE is 0, so there's no strong reason to move the rcu assign
after *x_conf init. It's already 0. You can replace the assignment
with WARN_ON(ctx->tx_conf != TLS_BASE) to make sure, and move that
into tls_ctx_create() instead of removing that function.
FWIW make sure you read this before posting v2:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
prev parent reply other threads:[~2023-11-10 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 10:57 [PATCH] tls: fix missing memory barrier in tls_init Dae R. Jeong
2023-11-10 14:19 ` kernel test robot
2023-11-10 19:15 ` kernel test robot
2023-11-10 19:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110114410.01cd3eb3@kernel.org \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=threeearcat@gmail.com \
--cc=ywchoi@casys.kaist.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).