From: Jakub Kicinski <kuba@kernel.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] ptp: annotate data-race around q->head and q->tail
Date: Fri, 10 Nov 2023 11:52:24 -0800 [thread overview]
Message-ID: <20231110115224.3d2f180c@kernel.org> (raw)
In-Reply-To: <ZU5j2V9aUae0FE1o@hoboy.vegasvil.org>
On Fri, 10 Nov 2023 09:09:45 -0800 Richard Cochran wrote:
> > I do not see how races are solved... Shouldn't
> > pccontext->private_clkdata be protected by RCU ?
>
> Yeah, the test is useless, because the memory is allocated in open()
> and later freed in release(). During ioctl() the pointer must be
> valid.
>
> However, there was a bogus call to ptp_release() in the read() method,
> but that has now been removed, and so the test is now bogus.
Meaning we should revert 8a4f030dbced ("ptp: Fixes a null pointer
dereference in ptp_ioctl") ?
next prev parent reply other threads:[~2023-11-10 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 17:48 [PATCH net] ptp: annotate data-race around q->head and q->tail Eric Dumazet
2023-11-10 4:23 ` Richard Cochran
2023-11-10 9:42 ` Eric Dumazet
2023-11-10 17:09 ` Richard Cochran
2023-11-10 19:52 ` Jakub Kicinski [this message]
2023-11-12 0:44 ` Richard Cochran
2023-11-14 4:52 ` Jakub Kicinski
2023-11-14 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110115224.3d2f180c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).