netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: <alexey.pakhunov@spacex.com>
Cc: <mchan@broadcom.com>, <vincent.wong2@spacex.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<siva.kallam@broadcom.com>, <prashant@broadcom.com>
Subject: Re: [PATCH v2 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi
Date: Fri, 10 Nov 2023 12:37:33 -0800	[thread overview]
Message-ID: <20231110123733.42f31ddb@kernel.org> (raw)
In-Reply-To: <20231110002340.3612515-1-alexey.pakhunov@spacex.com>

On Thu, 9 Nov 2023 16:23:39 -0800 alexey.pakhunov@spacex.com wrote:
> +		for (i = 0; i < TG3_IRQ_MAX_VECS; ++i)
> +		{

checkpatch says:

ERROR: that open brace { should be on the previous line 
-- 
pw-bot: cr

      parent reply	other threads:[~2023-11-10 20:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  0:23 [PATCH v2 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi alexey.pakhunov
2023-11-10  0:23 ` [PATCH v2 2/2] tg3: Increment tx_dropped in tg3_tso_bug() alexey.pakhunov
2023-11-10  4:56   ` Michael Chan
2023-11-10  4:55 ` [PATCH v2 1/2] tg3: Move the [rt]x_dropped counters to tg3_napi Michael Chan
2023-11-10 15:13 ` Andrew Lunn
2023-11-13 17:52   ` Alex Pakhunov
2023-11-10 20:37 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110123733.42f31ddb@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexey.pakhunov@spacex.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=prashant@broadcom.com \
    --cc=siva.kallam@broadcom.com \
    --cc=vincent.wong2@spacex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).