From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <brett.creeley@amd.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<drivers@pensando.io>, <joao.m.martins@oracle.com>
Subject: Re: [PATCH net 1/2] pds_core: use correct index to mask irq
Date: Fri, 10 Nov 2023 16:16:06 -0800 [thread overview]
Message-ID: <20231110161606.16f5af39@kernel.org> (raw)
In-Reply-To: <20231110200759.56770-2-shannon.nelson@amd.com>
On Fri, 10 Nov 2023 12:07:58 -0800 Shannon Nelson wrote:
> Use the qcq's interrupt index, not the irq number, to mask
> the interrupt.
Patch 2 is whatever, but this one really should say what practical
impact the change has (i.e. is it causing any user visible issues).
Has impact == should include a Fixes tag; no impact == net-next.
--
pw-bot: cr
next prev parent reply other threads:[~2023-11-11 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 20:07 [PATCH net 0/2] pds_core: fix irq index bug and compiler warnings Shannon Nelson
2023-11-10 20:07 ` [PATCH net 1/2] pds_core: use correct index to mask irq Shannon Nelson
2023-11-11 0:16 ` Jakub Kicinski [this message]
2023-11-10 20:07 ` [PATCH net 2/2] pds_core: fix up some format-truncation complaints Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110161606.16f5af39@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=joao.m.martins@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).