From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A53E249FA for ; Mon, 13 Nov 2023 22:52:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gkptuGKo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25099C433C7; Mon, 13 Nov 2023 22:52:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699915944; bh=UIvnWyXUtK4lhLZDh5Bp9ms/ksdAdZBHzb69ZVetNqI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gkptuGKoHWK/WcsX5MIfyzlhRy0HPBMxuMxHLCrh/Vqt1/ztx0biPUAmqhmTqESCz 4ow188sotvjjD/jAWtHjABtg5PfLH38lfrP3KyvBfi/Gh7KEYDgOTjwr1/NfuFVFlF SA7rgeWJB7UhwGK9s2+FbKCK4zxPet4fk1PYF1s0IGW8GH+yDsosxEJ13pczHqa4n2 sh7pA8EY9XEdBcdjdGKioobBveHISfTP+qEFJL20+CrLNDDE5kut8pMObkumrVsE25 tYdDC6SzlKQi14fJobsAedwiV+95rkT/RNwSvlYSd3BttSMe14KbubDbRUJbtpHJdt EBA8x6h3raNrg== Date: Mon, 13 Nov 2023 17:52:22 -0500 From: Jakub Kicinski To: Baruch Siach Cc: Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org Subject: Re: [PATCH net 2/2] net: stmmac: avoid rx queue overrun Message-ID: <20231113175222.674a3971@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 13 Nov 2023 19:42:50 +0200 Baruch Siach wrote: > dma_rx_size can be set as low as 64. Rx budget might be higher than > that. Make sure to not overrun allocated rx buffers when budget is > larger. > > Leave one descriptor unused to avoid wrap around of 'dirty_rx' vs > 'cur_rx'. Can we get a Fixes tag for this one as well?