From: Jakub Kicinski <kuba@kernel.org>
To: Li RongQing <lirongqing@baidu.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
Liam.Howlett@oracle.com, anjali.k.kulkarni@oracle.com,
leon@kernel.org, fw@strlen.de, shayagr@amazon.com,
idosch@nvidia.com, razor@blackwall.org, linyunsheng@huawei.com,
netdev@vger.kernel.org
Subject: Re: [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it in rtnl_getlink
Date: Tue, 14 Nov 2023 17:37:57 -0500 [thread overview]
Message-ID: <20231114173757.0910964e@kernel.org> (raw)
In-Reply-To: <20231114095522.27939-1-lirongqing@baidu.com>
On Tue, 14 Nov 2023 17:55:22 +0800 Li RongQing wrote:
> - nskb = nlmsg_new(if_nlmsg_size(dev, ext_filter_mask), GFP_KERNEL);
> + nskb = vnlmsg_new(if_nlmsg_size(dev, ext_filter_mask));
Why vnlmsg_new()? nlmsg_ is a prefix, for netlink message.
prefixes do not combine like you're trying to make them.
Can you call it nlmsg_new_large() or similar?
> if (nskb == NULL)
> goto out;
>
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index eb086b0..17587f1 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1204,7 +1204,7 @@ struct sock *netlink_getsockbyfilp(struct file *filp)
> return sock;
> }
>
> -static struct sk_buff *netlink_alloc_large_skb(unsigned int size,
> +struct sk_buff *netlink_alloc_large_skb(unsigned int size,
> int broadcast)
You need to fix the alignment of the continuation line.
Perhaps it now fits in 80chars so line break is not needed?
next prev parent reply other threads:[~2023-11-14 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:55 [PATCH][net-next][v2] rtnetlink: instroduce vnlmsg_new and use it in rtnl_getlink Li RongQing
2023-11-14 11:31 ` Yunsheng Lin
2023-11-14 12:02 ` Li,Rongqing
2023-11-14 22:37 ` Jakub Kicinski [this message]
2023-11-15 8:16 ` Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114173757.0910964e@kernel.org \
--to=kuba@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=idosch@nvidia.com \
--cc=leon@kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).