netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Luca Boccassi <luca.boccassi@gmail.com>
Subject: Re: [PATCH iproute2] Makefile: use /usr/share/iproute2 for config files
Date: Tue, 14 Nov 2023 19:37:32 -0800	[thread overview]
Message-ID: <20231114193732.31926e3c@hermes.local> (raw)
In-Reply-To: <c26af87143b645cc19ce93e4624923ef3f25204d.1699707062.git.aclaudi@redhat.com>

On Sat, 11 Nov 2023 13:55:41 +0100
Andrea Claudi <aclaudi@redhat.com> wrote:

> CONF_USR_DIR was initially set to $(PREFIX)/lib/iproute2, then moved to
> $(LIBDIR)/iproute2 to honour the libdir user config. However, as
> reported by Luca, most distros use an arch-dependent LIBDIR, which is
> the wrong directory to place architecture-independent configuration
> files.
> 
> According to FHS:
> 
> "/usr/lib includes object files and libraries. On some systems, it may
> also include internal binaries that are not intended to be executed
> directly by users or shell scripts."
> 
> A better directory to store config files is /usr/share:
> 
> "The /usr/share hierarchy is for all read-only architecture independent
> data files.
> 
> This hierarchy is intended to be shareable among all architecture
> platforms of a given OS; thus, for example, a site with i386, Alpha, and
> PPC platforms might maintain a single /usr/share directory that is
> centrally-mounted."
> 
> Accordingly, move configuration files to $(DATADIR)/iproute2.
> 
> Fixes: 946753a4459b ("Makefile: ensure CONF_USR_DIR honours the libdir config")
> Reported-by: Luca Boccassi <luca.boccassi@gmail.com>
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>

Since revert patch from Luca is merged already, please rebase and resubmit this.

      parent reply	other threads:[~2023-11-15  3:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:55 [PATCH iproute2] Makefile: use /usr/share/iproute2 for config files Andrea Claudi
2023-11-11 16:56 ` Luca Boccassi
2023-11-15  3:37 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231114193732.31926e3c@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=aclaudi@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=luca.boccassi@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).