From: Simon Horman <horms@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: improve RTL8411b phy-down fixup
Date: Wed, 15 Nov 2023 17:35:02 +0000 [thread overview]
Message-ID: <20231115173502.GT74656@kernel.org> (raw)
In-Reply-To: <f1a5f918-e9fd-48e6-8956-2c79648e563e@gmail.com>
On Mon, Nov 13, 2023 at 08:13:26PM +0100, Heiner Kallweit wrote:
> Mirsad proposed a patch to reduce the number of spinlock lock/unlock
> operations and the function code size. This can be further improved
> because the function sets a consecutive register block.
>
> Suggested-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 139 +++++-----------------
> 1 file changed, 28 insertions(+), 111 deletions(-)
Nice. Less code and fewer locks.
I manually verified that fix_data matches the code it replaces.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-15 17:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 19:13 [PATCH net-next] r8169: improve RTL8411b phy-down fixup Heiner Kallweit
2023-11-15 17:35 ` Simon Horman [this message]
2023-11-15 22:17 ` Mirsad Todorovac
2023-11-16 5:56 ` Mirsad Todorovac
2023-11-17 6:43 ` Heiner Kallweit
2023-11-18 18:24 ` Jakub Kicinski
2023-11-18 22:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115173502.GT74656@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).