From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, fw@strlen.de
Subject: [PATCH net 2/6] netfilter: nf_conntrack_bridge: initialize err to 0
Date: Wed, 15 Nov 2023 19:45:10 +0100 [thread overview]
Message-ID: <20231115184514.8965-3-pablo@netfilter.org> (raw)
In-Reply-To: <20231115184514.8965-1-pablo@netfilter.org>
From: Linkui Xiao <xiaolinkui@kylinos.cn>
K2CI reported a problem:
consume_skb(skb);
return err;
[nf_br_ip_fragment() error] uninitialized symbol 'err'.
err is not initialized, because returning 0 is expected, initialize err
to 0.
Fixes: 3c171f496ef5 ("netfilter: bridge: add connection tracking system")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Linkui Xiao <xiaolinkui@kylinos.cn>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/bridge/netfilter/nf_conntrack_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/netfilter/nf_conntrack_bridge.c b/net/bridge/netfilter/nf_conntrack_bridge.c
index b5c406a6e765..abb090f94ed2 100644
--- a/net/bridge/netfilter/nf_conntrack_bridge.c
+++ b/net/bridge/netfilter/nf_conntrack_bridge.c
@@ -37,7 +37,7 @@ static int nf_br_ip_fragment(struct net *net, struct sock *sk,
ktime_t tstamp = skb->tstamp;
struct ip_frag_state state;
struct iphdr *iph;
- int err;
+ int err = 0;
/* for offloaded checksums cleanup checksum before fragmentation */
if (skb->ip_summed == CHECKSUM_PARTIAL &&
--
2.30.2
next prev parent reply other threads:[~2023-11-15 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 18:45 [PATCH net 0/6] Netfilter fixes for net Pablo Neira Ayuso
2023-11-15 18:45 ` [PATCH net 1/6] netfilter: nft_set_rbtree: Remove unused variable nft_net Pablo Neira Ayuso
2023-11-16 10:29 ` patchwork-bot+netdevbpf
2023-11-15 18:45 ` Pablo Neira Ayuso [this message]
2023-11-15 18:45 ` [PATCH net 3/6] netfilter: nf_tables: fix pointer math issue in nft_byteorder_eval() Pablo Neira Ayuso
2023-11-15 18:45 ` [PATCH net 4/6] netfilter: nf_tables: bogus ENOENT when destroying element which does not exist Pablo Neira Ayuso
2023-11-15 18:45 ` [PATCH net 5/6] netfilter: ipset: fix race condition between swap/destroy and kernel side add/del/test Pablo Neira Ayuso
2023-11-15 18:45 ` [PATCH net 6/6] netfilter: nf_tables: split async and sync catchall in two functions Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115184514.8965-3-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).