Re: [PATCH v4 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode

Jie Luo
2023-11-17T09:45:52Z

On 11/17/2023 2:12 AM, Andrew Lunn wrote:
> On Thu, Nov 16, 2023 at 02:22:41PM +0000, Conor Dooley wrote:
>> On Thu, Nov 16, 2023 at 07:24:33PM +0800, Luo Jie wrote:
>>> Add the new interface mode 10g-qxgmii, which is similar to
>>> usxgmii but extend to 4 channels to support maximum of 4
>>> ports with the link speed 10M/100M/1G/2.5G.
>>>
>>
>>> This patch is separated from Vladimir Oltean's previous patch
>>> <net: phy: introduce core support for phy-mode = "10g-qxgmii">.
>>
>> This belongs in the changelog under the --- line.
>>
>>>
>>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>>
>> Are you missing a from: line in this patch?
>
> You probably need to use git commit --am --author=<author> to fix
> this.
>
> Andrew

will update this in the next patch set, thanks for this instruction.