From: Stephen Hemminger <stephen@networkplumber.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: netdev@vger.kernel.org, bjorn@mork.no
Subject: Re: [RFC] usbnet: assign unique random MAC
Date: Thu, 16 Nov 2023 10:49:25 -0800 [thread overview]
Message-ID: <20231116104925.302865a8@hermes.local> (raw)
In-Reply-To: <20231116123033.26035-1-oneukum@suse.com>
On Thu, 16 Nov 2023 13:30:24 +0100
Oliver Neukum <oneukum@suse.com> wrote:
> module_exit(usbnet_exit);
>
> +module_param(legacymac, bool, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(legacymac, "Use a legacy style common MAC if device need a random MAC");
> MODULE_AUTHOR("David Brownell");
Module params are bad idea, just do the right thing.
next prev parent reply other threads:[~2023-11-16 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 12:30 [RFC] usbnet: assign unique random MAC Oliver Neukum
2023-11-16 12:39 ` Bjørn Mork
2023-11-16 13:02 ` Oliver Neukum
2023-11-16 13:21 ` Bjørn Mork
2023-11-16 13:29 ` Oliver Neukum
2023-11-16 14:49 ` Bjørn Mork
2023-11-16 17:45 ` Oliver Neukum
2023-11-16 21:47 ` Andrew Lunn
2023-11-16 18:49 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-16 14:05 Oliver Neukum
2023-11-16 18:51 ` Stephen Hemminger
2023-11-16 20:48 ` Benjamin Poirier
2023-11-20 10:44 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116104925.302865a8@hermes.local \
--to=stephen@networkplumber.org \
--cc=bjorn@mork.no \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).