From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Chuck Lever <chuck.lever@oracle.com>,
linux-afs@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rxrpc_find_service_conn_rcu: use read_seqbegin() rather than read_seqbegin_or_lock()
Date: Thu, 16 Nov 2023 16:06:50 +0100 [thread overview]
Message-ID: <20231116150650.GF18748@redhat.com> (raw)
In-Reply-To: <112162.1700146930@warthog.procyon.org.uk>
On 11/16, David Howells wrote:
>
> Oleg Nesterov <oleg@redhat.com> wrote:
>
> > > > - the usage of read_seqbegin_or_lock/need_seqretry in
> > > > this code makes no sense because read_seqlock_excl()
> > > > is not possible
> > >
> > > Not exactly. I think it should take a lock on the second pass.
> >
> > OK, then how about the patch below?
>
> That seems to work.
OK, I'll send V2 tomorrow.
Should I change fs/afs the same way?
Oleg.
prev parent reply other threads:[~2023-11-16 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 9:58 [PATCH] rxrpc_find_service_conn_rcu: use read_seqbegin() rather than read_seqbegin_or_lock() Oleg Nesterov
2023-10-27 10:00 ` Oleg Nesterov
2023-11-01 15:45 ` David Howells
2023-11-01 20:23 ` Oleg Nesterov
2023-11-01 20:40 ` Oleg Nesterov
2023-11-01 21:22 ` David Howells
2023-11-01 22:38 ` Oleg Nesterov
2023-11-01 20:52 ` Al Viro
2023-11-01 21:52 ` Oleg Nesterov
2023-11-01 22:48 ` Al Viro
2023-11-01 23:17 ` Oleg Nesterov
2023-11-01 21:20 ` David Howells
2023-11-01 22:15 ` Oleg Nesterov
2023-11-01 22:29 ` Oleg Nesterov
2023-11-16 13:18 ` Oleg Nesterov
2023-11-16 13:41 ` David Howells
2023-11-16 14:19 ` Oleg Nesterov
2023-11-16 15:02 ` David Howells
2023-11-16 15:06 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116150650.GF18748@redhat.com \
--to=oleg@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).