* [net PATCH] octeontx2-pf: Fix memory leak during interface down
@ 2023-11-16 15:53 Suman Ghosh
2023-11-16 20:50 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Suman Ghosh @ 2023-11-16 15:53 UTC (permalink / raw)
To: sgoutham, gakula, sbhatta, hkelam, lcherian, jerinj, davem,
edumazet, kuba, pabeni, netdev, linux-kernel, horms
Cc: Suman Ghosh
During 'ifconfig <netdev> down' one RSS memory was not getting freed.
This patch fixes the same.
Fixes: f12098ce9b43 ("octeontx2-pf: Clear RSS enable flag on interace down")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
index 91b99fd70361..ba95ac913274 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
@@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev)
/* Clear RSS enable flag */
rss = &pf->hw.rss_info;
rss->enable = false;
+ if (!netif_is_rxfh_configured(netdev))
+ kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]);
/* Cleanup Queue IRQ */
vec = pci_irq_vector(pf->pdev,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net PATCH] octeontx2-pf: Fix memory leak during interface down
2023-11-16 15:53 [net PATCH] octeontx2-pf: Fix memory leak during interface down Suman Ghosh
@ 2023-11-16 20:50 ` Simon Horman
2023-11-17 10:25 ` [EXT] " Suman Ghosh
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2023-11-16 20:50 UTC (permalink / raw)
To: Suman Ghosh
Cc: sgoutham, gakula, sbhatta, hkelam, lcherian, jerinj, davem,
edumazet, kuba, pabeni, netdev, linux-kernel
On Thu, Nov 16, 2023 at 09:23:34PM +0530, Suman Ghosh wrote:
> During 'ifconfig <netdev> down' one RSS memory was not getting freed.
> This patch fixes the same.
>
> Fixes: f12098ce9b43 ("octeontx2-pf: Clear RSS enable flag on interace down")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
Hi Suman,
I'm wondering if the fixes tag should refer to the commit
that introduced the allocation that your patch is freeing.
Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support")
> ---
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 91b99fd70361..ba95ac913274 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev)
> /* Clear RSS enable flag */
> rss = &pf->hw.rss_info;
> rss->enable = false;
> + if (!netif_is_rxfh_configured(netdev))
> + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]);
>
> /* Cleanup Queue IRQ */
> vec = pci_irq_vector(pf->pdev,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] Re: [net PATCH] octeontx2-pf: Fix memory leak during interface down
2023-11-16 20:50 ` Simon Horman
@ 2023-11-17 10:25 ` Suman Ghosh
0 siblings, 0 replies; 3+ messages in thread
From: Suman Ghosh @ 2023-11-17 10:25 UTC (permalink / raw)
To: Simon Horman
Cc: Sunil Kovvuri Goutham, Geethasowjanya Akula,
Subbaraya Sundeep Bhatta, Hariprasad Kelam, Linu Cherian,
Jerin Jacob Kollanukkaran, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
>Hi Suman,
>
>I'm wondering if the fixes tag should refer to the commit that introduced
>the allocation that your patch is freeing.
[Suman] Yes, that make sense. I will update in v2.
>
>Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support")
>
>> ---
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> index 91b99fd70361..ba95ac913274 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev)
>> /* Clear RSS enable flag */
>> rss = &pf->hw.rss_info;
>> rss->enable = false;
>> + if (!netif_is_rxfh_configured(netdev))
>> + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]);
>>
>> /* Cleanup Queue IRQ */
>> vec = pci_irq_vector(pf->pdev,
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-17 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 15:53 [net PATCH] octeontx2-pf: Fix memory leak during interface down Suman Ghosh
2023-11-16 20:50 ` Simon Horman
2023-11-17 10:25 ` [EXT] " Suman Ghosh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).