From: Jakub Kicinski <kuba@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
vladimir.oltean@nxp.com, s-vadapalli@ti.com,
r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: ti: am65-cpsw-nuss: Fix NULL pointer dereference at module removal
Date: Sat, 18 Nov 2023 20:44:24 -0800 [thread overview]
Message-ID: <20231118204424.21d209a6@kernel.org> (raw)
In-Reply-To: <20231116110930.36244-3-rogerq@kernel.org>
On Thu, 16 Nov 2023 13:09:30 +0200 Roger Quadros wrote:
> The NULL pointer derefernce error seems to come from the
> list_for_each_entry_safe() helper in free_netdev(). It looks like
> the napi pointers are stale contents but I coudn't figure out why.
Some interplay with am65_cpsw_nuss_free_tx_chns()?
It does:
memset(tx_chn, 0, sizeof(*tx_chn));
which will wipe the NAPI instance, including its struct list_head.
AFAICT the patch as posted misses free_netdev() on some error paths.
--
pw-bot: cr
prev parent reply other threads:[~2023-11-19 4:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 11:09 [PATCH net 0/2] net: ti: am65-cpsw-nuss: module removal fixes for v6.7-rc Roger Quadros
2023-11-16 11:09 ` [PATCH net 1/2] net: ti: am65-cpsw-nuss: Fix devlink warning on module removal Roger Quadros
2023-11-16 11:09 ` [PATCH net 2/2] net: ti: am65-cpsw-nuss: Fix NULL pointer dereference at " Roger Quadros
2023-11-19 4:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231118204424.21d209a6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).