From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OiEUm9QF" Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B515F2; Sun, 19 Nov 2023 06:40:44 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c79d8b67f3so43499781fa.0; Sun, 19 Nov 2023 06:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700404842; x=1701009642; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5ZI6+aQ9+c+bpfwBYIcSU777SeZBaK2MLQMxaHGRpFI=; b=OiEUm9QFSNEg91mUf5F9nvElGp3BqlxbGkMmoFkVZQjSIl3Cc+J6oI+PYFjH1Yktft 8cocuDDr8/2JOlz+29xLDOOa+6GFXgui9m9qNzQ4xE6yIj+6kMwtm8pzOIQik5pefzrk jJZMolZ/D5RdutkZGDc83NluZUstx4LSLRHfJmO7w6fSNl6za5wBD6cqsN5vbngXlDy6 TvdyhfaTEsZn63URdl8r0MqG7f2g+eSUwiMGctTO+arwKgvYOuXjxj7VEoai0cSAuzEK 8KPoynhIVv+iQOfzLbLlnAJkzdtKsq4f6xLPCfpVHpKcRtY8Npc4aQLD6+epgi3lQ41f FTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700404842; x=1701009642; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ZI6+aQ9+c+bpfwBYIcSU777SeZBaK2MLQMxaHGRpFI=; b=bD79H/fpnTiv5p+vtxExhG3uWKzfEk/OQksRjR8/K8nhOOrrpd5Jkc0ORrXy9O27T0 rILJwr7T8/gxfEO0mq0jNYWa9b3QrxnKwe3q1SrDQlihDT58SfY9Kpg4uSkuXCum/nLz /NFIy3naX3+By2O5zamkuEywdNVlhR/sQ6Ufa1uGzSnbyCXWo/3cgff9ET1r79kRQ49U 0p6LZ1BNZwVFeIfBhd1ekew2no5PRVeZTwjN01CjdVilD0gvIDkGUPcGRdpZTiHZK050 Pvi27AaezJKBDbbRzBRyb+4RbIn6idVlEiOPHueIwvvyaM90SmSCo1cxQFKuBpSgTnDN zbqA== X-Gm-Message-State: AOJu0Yzb+evu48fuN3kl8OjgVnYZ7uW0Pn0ZdLpQliqJkXPQSeT2dsXg 3FYaz9lpaxZ1gINn0+fjK4E= X-Google-Smtp-Source: AGHT+IGz3Am6v44VUwMqk25WU74XtddrbbJsFHcdTLt3huXceX43GKRCbBwubtG0I1e4Th/6uBbTrg== X-Received: by 2002:a2e:2245:0:b0:2c8:713c:b506 with SMTP id i66-20020a2e2245000000b002c8713cb506mr3263978lji.43.1700404842251; Sun, 19 Nov 2023 06:40:42 -0800 (PST) Received: from skbuf ([188.26.185.114]) by smtp.gmail.com with ESMTPSA id a3-20020a05600c348300b0040a5e69482esm14598744wmq.11.2023.11.19.06.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 06:40:42 -0800 (PST) Date: Sun, 19 Nov 2023 16:40:39 +0200 From: Vladimir Oltean To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com Subject: Re: [PATCH net-next 02/15] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel Message-ID: <20231119144039.gvbima26zhktf6bd@skbuf> References: <20231118123205.266819-1-arinc.unal@arinc9.com> <20231118123205.266819-3-arinc.unal@arinc9.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231118123205.266819-3-arinc.unal@arinc9.com> On Sat, Nov 18, 2023 at 03:31:52PM +0300, Arınç ÜNAL wrote: > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Remove the explicit assignment of 0 to P5_DISABLED as the first enum item > is automatically assigned 0. > > Signed-off-by: Arınç ÜNAL > Acked-by: Daniel Golle > --- Reviewed-by: Vladimir Oltean