From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GVf/Trvc" Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14824C2 for ; Sun, 19 Nov 2023 08:46:30 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-32dc9ff4a8fso2261226f8f.1 for ; Sun, 19 Nov 2023 08:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700412388; x=1701017188; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yew85HukruHEIfiVkzSCVXbKQFzW/CoGnMWrA/YD6Qc=; b=GVf/TrvcxibNo67XNpomKq4njqDxwnfQLM3EuVWVkI0w542aX+evi4CjVpOk9m58Yd lPpWzfACIfms70nArTRGrcfGA0Nb3lqPHZ1mpvBzBmCTkHV9ORMbfgfLJChgbnoCMif8 qZlqRzMdFoUFTB85+n9aYyD2MAby0R5VPo1gSzkPsk/HsuFauSiSzvHZjLOX0/nXbOFS rVcr7lpxW5PWVfFL9W/hIRoTFk4kEpLBWjRJWtDqejaRCnZzrfQ9Bp0xOnqAgwc2TArW 8qnRZp3nbbwULjnxS2VpWGEa66HLrTsHboUduYpJnTEPo9FUeXTS0tOTbkCKcig/+Va8 PX6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700412388; x=1701017188; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yew85HukruHEIfiVkzSCVXbKQFzW/CoGnMWrA/YD6Qc=; b=WrtqSTmNpP1dfXt+mLKFtvZ1RGN/whE7ohKWzvjhUEcSnO2N3ZQLcrWzTJX5vdHzVk XKE8H+wC6/s9NoiWjGFH/rRqD7VirwC3Mkfkmy++lToniXy6/2Mtyc7QVqW+FUkcsGI8 7YBPZ/G50zwV0boi5ZoQ0XEjgP7hlsKD7OFAALwj1gpyuBFB2LrK8yUMgltB9v5EDfvB gK/Q6mtpzo6B0SWe6ILsEclW4Dvpn+Jy78pqgVn6Z+6ry3c8iT4LjsoaWdXQg/gawGUE fWUj6Px7Ay2HXq9rYx1qmeTOH1VpVAj7/XBLqZntdfWN5cZoxl1GSpfH6UkZE212TRaC oi5A== X-Gm-Message-State: AOJu0YxqHlDu4OJhyh8AQJ1MXYIlwf07AHZVTxMb9G0EUB2kJC+zSbcc MJjtyQKVgZ6+s8ptUjDO5ze4jD7Tyfw= X-Google-Smtp-Source: AGHT+IGHjTXsj482taPiGXBKG+xjnMcjGCp7Hci8dpHC7e8jbCHXTEq4DmRZKsyGcaSTBP9eXwU6CQ== X-Received: by 2002:a5d:5f42:0:b0:331:3cec:215a with SMTP id cm2-20020a5d5f42000000b003313cec215amr5265779wrb.8.1700412388257; Sun, 19 Nov 2023 08:46:28 -0800 (PST) Received: from skbuf ([188.26.185.114]) by smtp.gmail.com with ESMTPSA id r12-20020adfda4c000000b003232380ffd7sm8446846wrl.102.2023.11.19.08.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 08:46:28 -0800 (PST) Date: Sun, 19 Nov 2023 18:46:25 +0200 From: Vladimir Oltean To: Hangbin Liu Cc: netdev@vger.kernel.org, "David S . Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Nikolay Aleksandrov , Roopa Prabhu , Stephen Hemminger , Florian Westphal , Andrew Lunn , Florian Fainelli , Jiri Pirko , Marc Muehlfeld Subject: Re: [PATCH net-next 01/10] net: bridge: add document for IFLA_BR enum Message-ID: <20231119164625.d2yzi3mpxv72t6pp@skbuf> References: <20231117093145.1563511-1-liuhangbin@gmail.com> <20231117093145.1563511-2-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231117093145.1563511-2-liuhangbin@gmail.com> On Fri, Nov 17, 2023 at 05:31:36PM +0800, Hangbin Liu wrote: > + * @IFLA_BR_MAX_AGE > + * The hello packet timeout, is the time until another bridge in the No comma between subject and predicate. > + * spanning tree is assumed to be dead, after reception of its last hello > + * message. Only relevant if STP is enabled. > + * > + * The valid values are between (6 * USER_HZ) and (40 * USER_HZ). > + * The default value is (20 * USER_HZ). > + * > + * @IFLA_BR_GROUP_FWD_MASK > + * The group forward mask. This is the bitmask that is applied to > + * decide whether to forward incoming frames destined to link-local > + * addresses. The addresses of the form is 01:80:C2:00:00:0X, which > + * means the bridge does not forward any link-local frames coming on > + * this port). > + * > + * The default value is 0. I'm confused by this description, I believe some of the wording is misplaced. Maybe: The group forwarding mask. This is the bitmask that is applied to decide whether to forward incoming frames destined to link-local addresses (of the form 01:80:C2:00:00:0X). The default value is 0, which means the bridge does not forward any link-local frames coming on this port. > + * @IFLA_BR_VLAN_DEFAULT_PVID > + * The default PVID (native/untagged VLAN ID) for this bridge. I don't think that "native VLAN" is a good description of this. The native VLAN should be the only egress-untagged VLAN of a port. I would say "VLAN ID applied to untagged and priority-tagged incoming packets". > + * > + * The default value is 1. I would also mention that the special value of 0 makes all ports of this bridge not have a PVID by default, which means that they will not accept VLAN-untagged traffic.