From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH] net: phy: correctly check soft_reset ret ONLY if defined for PHY
Date: Mon, 20 Nov 2023 13:53:03 -0800 [thread overview]
Message-ID: <20231120135303.0e64bc81@kernel.org> (raw)
In-Reply-To: <655bb7e5.5d0a0220.59243.9a2c@mx.google.com>
On Mon, 20 Nov 2023 17:50:53 +0100 Christian Marangi wrote:
> On Mon, Nov 20, 2023 at 09:42:34AM -0800, Jakub Kicinski wrote:
> > On Mon, 20 Nov 2023 14:15:40 +0100 Christian Marangi wrote:
> > > Luckly nothing was ever added before the soft_reset call so the ret
> > > check (in the case where a PHY didn't had soft_reset defined) although
> > > wrong, never caused problems as ret was init 0 at the start of
> > > phy_init_hw.
> >
> > not currently a bug => no Fixes tag, please
>
> I know it's not a bug but still the referenced commit was wrong. Can I
> at least use Ref to reference it?
Not sure what you mean by "Ref"
> Due to the changes done to this function, it's hard to catch where the
> problem arised with a git blame.
Right, and you already quote the commit in the body. No objections to
repeating that if you want, maybe:
Introduced by commit 6e2d85ec0559 ("net: phy: Stop with excessive soft
reset").
but as a part of the "body" of the commit message, not tags.
prev parent reply other threads:[~2023-11-20 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 13:15 [net-next PATCH] net: phy: correctly check soft_reset ret ONLY if defined for PHY Christian Marangi
2023-11-20 17:15 ` Larysa Zaremba
2023-11-20 16:49 ` Christian Marangi
2023-11-21 9:09 ` Larysa Zaremba
2023-11-20 17:42 ` Jakub Kicinski
2023-11-20 16:50 ` Christian Marangi
2023-11-20 21:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120135303.0e64bc81@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).