netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Michal Michalik <michal.michalik@intel.com>
Cc: netdev@vger.kernel.org, vadim.fedorenko@linux.dev,
	arkadiusz.kubalewski@intel.com, jonathan.lemon@gmail.com,
	pabeni@redhat.com, poros@redhat.com, milena.olech@intel.com,
	mschmidt@redhat.com, linux-clk@vger.kernel.org,
	bvanassche@acm.org, kuba@kernel.org, davem@davemloft.net,
	edumazet@google.com
Subject: Re: [PATCH RFC net-next v3 2/2] selftests/dpll: add DPLL system integration selftests
Date: Mon, 20 Nov 2023 17:16:31 +0000	[thread overview]
Message-ID: <20231120171631.GB245676@kernel.org> (raw)
In-Reply-To: <20231117190505.7819-3-michal.michalik@intel.com>

On Fri, Nov 17, 2023 at 08:05:05PM +0100, Michal Michalik wrote:
> The tests are written in Python3 (3.7+) and pytest testing framework.
> Framework is basing on the ynl library available in the kernel tree
> at: tools/net/ynl
> 
> High level flow of DPLL subsystem integration selftests:
> (after running run_dpll_tests.sh or 'make -C tools/testing/selftests')
> 1) check if Python in correct version is installed,
> 2) create temporary Python virtual environment,
> 3) install all the required libraries,
> 4) run the tests,
> 5) do cleanup.
> 
> The DPLL system integration tests are meant to be part of selftests, so
> they can be build and run using command:
>   make -C tools/testing/selftests
> 
> Alternatively, they can be run using single command [1]:
>   make kselftest
> 
> If we want to run only DPLL tests, we should set the TARGETS variable:
>   make -C tools/testing/selftests TARGETS=drivers/net/netdevsim/dpll
> 
> They can also be run standalone using starter script:
>   ./run_dpll_tests.sh
> 
> There is a possibliy to set optional PYTEST_PARAMS environment variable
> to set the pytest options, like tests filtering ("-k <filter>") or
> verbose output ("-v").
> 
> [1] https://www.kernel.org/doc/html/v5.0/dev-tools/kselftest.html
> 
> Signed-off-by: Michal Michalik <michal.michalik@intel.com>

...

> diff --git a/tools/testing/selftests/drivers/net/netdevsim/dpll/run_dpll_tests.sh b/tools/testing/selftests/drivers/net/netdevsim/dpll/run_dpll_tests.sh
> new file mode 100755
> index 0000000..3bed221
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/netdevsim/dpll/run_dpll_tests.sh
> @@ -0,0 +1,75 @@
> +#!/usr/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Wraper script for running the DPLL system integration tests.

nit: Wrapper

     Also elsewhere in this patch.

...

  reply	other threads:[~2023-11-20 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 19:05 [PATCH RFC net-next v3 0/2] selftests/dpll: DPLL subsystem integration tests Michal Michalik
2023-11-17 19:05 ` [PATCH RFC net-next v3 1/2] netdevsim: implement DPLL for subsystem selftests Michal Michalik
2023-11-20 17:15   ` Simon Horman
2023-11-22 16:49     ` Michalik, Michal
2023-11-17 19:05 ` [PATCH RFC net-next v3 2/2] selftests/dpll: add DPLL system integration selftests Michal Michalik
2023-11-20 17:16   ` Simon Horman [this message]
2023-11-22 16:53     ` Michalik, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120171631.GB245676@kernel.org \
    --to=horms@kernel.org \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=bvanassche@acm.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=michal.michalik@intel.com \
    --cc=milena.olech@intel.com \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=poros@redhat.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).