From: Simon Horman <horms@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
shuah@kernel.org, victor@mojatatu.com
Subject: Re: [PATCH net-next 5/6] selftests: tc-testing: timeout on unbounded loops
Date: Mon, 20 Nov 2023 17:35:55 +0000 [thread overview]
Message-ID: <20231120173555.GE245676@kernel.org> (raw)
In-Reply-To: <20231117171208.2066136-6-pctammela@mojatatu.com>
On Fri, Nov 17, 2023 at 02:12:07PM -0300, Pedro Tammela wrote:
> In the spirit of failing early, timeout on unbounded loops that take
> longer than 20 ticks to complete. Such loops are to ensure that objects
> created are already visible so tests can proceed without any issues.
>
> If a test setup takes more than 20 ticks to see an object, there's
> definetely something wrong.
>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Hi Pedro,
no need to respin because of this, but 'definitely' is misspelt above.
Moving on, I am very pleased to see these loops become bounded in time.
So the above nit notwithstanding,
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2023-11-20 17:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 17:12 [PATCH net-next 0/6] selftests: tc-testing: more updates to tdc Pedro Tammela
2023-11-17 17:12 ` [PATCH net-next 1/6] selftests: tc-testing: cap parallel tdc to 4 cores Pedro Tammela
2023-11-20 17:38 ` Simon Horman
2023-11-17 17:12 ` [PATCH net-next 2/6] selftests: tc-testing: move back to per test ns setup Pedro Tammela
2023-11-20 17:38 ` Simon Horman
2023-11-17 17:12 ` [PATCH net-next 3/6] selftests: tc-testing: use netns delete from pyroute2 Pedro Tammela
2023-11-20 17:35 ` Simon Horman
2023-11-17 17:12 ` [PATCH net-next 4/6] selftests: tc-testing: leverage -all in suite ns teardown Pedro Tammela
2023-11-20 17:39 ` Simon Horman
2023-11-17 17:12 ` [PATCH net-next 5/6] selftests: tc-testing: timeout on unbounded loops Pedro Tammela
2023-11-20 17:35 ` Simon Horman [this message]
2023-11-17 17:12 ` [PATCH net-next 6/6] selftests: tc-testing: report number of workers in use Pedro Tammela
2023-11-20 17:40 ` Simon Horman
2023-11-17 20:47 ` [PATCH net-next 0/6] selftests: tc-testing: more updates to tdc Jamal Hadi Salim
2023-11-21 2:07 ` Jakub Kicinski
2023-11-21 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231120173555.GE245676@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=shuah@kernel.org \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).