From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, almasrymina@google.com,
ilias.apalodimas@linaro.org, dsahern@gmail.com,
dtatulea@nvidia.com, kernel-team <kernel-team@cloudflare.com>
Subject: Re: [PATCH net-next v2 12/15] net: page_pool: report when page pool was destroyed
Date: Tue, 21 Nov 2023 13:49:08 -0800 [thread overview]
Message-ID: <20231121134908.54619aa5@kernel.org> (raw)
In-Reply-To: <e64de1a2-a9c6-43e0-8036-7be7fbf18d52@kernel.org>
On Tue, 21 Nov 2023 21:45:57 +0100 Jesper Dangaard Brouer wrote:
> Hmm, this is called when kernel could *NOT* destroy the PP, but have to
> start a work-queue that will retry deleting this. Thus, I think naming
> this "destroyed" is confusing as I then assumed was successfully
> destroyed, but it is not, instead it is on "deathrow".
I wasn't sure what to call it so I called what the driver API is
called...
"deathrow" does not sound very intuitive to me. How about "detached"
or "removed"?
> Could we place this PP instance on another list of PP instances about to
> be deleted?
>
> (e.g. a deathrow or sched_destroy list)
Is there a need for that?
I mean - many interesting extensions to this API are possible.
I don't think they should all can all be here from day 1..
> Perhaps this could also allow us to list those PP instances that
> no-longer have a netdev associated?
The current implementation uses loopback for that, since it's naturally
tied to a name space.
next prev parent reply other threads:[~2023-11-21 21:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 0:00 [PATCH net-next v2 00/15] net: page_pool: add netlink-based introspection Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 01/15] net: page_pool: split the page_pool_params into fast and slow Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 02/15] net: page_pool: avoid touching slow on the fastpath Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 03/15] net: page_pool: factor out uninit Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 04/15] net: page_pool: id the page pools Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 05/15] net: page_pool: record pools per netdev Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 06/15] net: page_pool: stash the NAPI ID for easier access Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 07/15] eth: link netdev to page_pools in drivers Jakub Kicinski
2023-11-21 13:13 ` kernel test robot
2023-11-21 21:25 ` kernel test robot
2023-11-21 0:00 ` [PATCH net-next v2 08/15] net: page_pool: add nlspec for basic access to page pools Jakub Kicinski
2023-11-21 18:24 ` Willem de Bruijn
2023-11-21 20:37 ` Jakub Kicinski
2023-11-21 21:33 ` Willem de Bruijn
2023-11-21 22:00 ` Jakub Kicinski
2023-11-21 22:49 ` David Ahern
2023-11-21 23:42 ` Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 09/15] net: page_pool: implement GET in the netlink API Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 10/15] net: page_pool: add netlink notifications for state changes Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 11/15] net: page_pool: report amount of memory held by page pools Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 12/15] net: page_pool: report when page pool was destroyed Jakub Kicinski
2023-11-21 20:45 ` Jesper Dangaard Brouer
2023-11-21 21:49 ` Jakub Kicinski [this message]
2023-11-22 8:53 ` Jesper Dangaard Brouer
2023-11-21 0:00 ` [PATCH net-next v2 13/15] net: page_pool: expose page pool stats via netlink Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 14/15] net: page_pool: mute the periodic warning for visible page pools Jakub Kicinski
2023-11-21 0:00 ` [PATCH net-next v2 15/15] tools: ynl: add sample for getting page-pool information Jakub Kicinski
2023-11-22 1:31 ` [PATCH net-next v2 00/15] net: page_pool: add netlink-based introspection Jakub Kicinski
2023-11-22 8:45 ` Jesper Dangaard Brouer
2023-11-22 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121134908.54619aa5@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).