From: Jakub Kicinski <kuba@kernel.org>
To: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, longli@microsoft.com,
sharmaajay@microsoft.com, leon@kernel.org, cai.huoqing@linux.dev,
ssengar@linux.microsoft.com, vkuznets@redhat.com,
tglx@linutronix.de, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, schakrabarti@microsoft.com,
paulros@microsoft.com
Subject: Re: [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores
Date: Tue, 21 Nov 2023 15:48:41 -0800 [thread overview]
Message-ID: <20231121154841.7fc019c8@kernel.org> (raw)
In-Reply-To: <1700574877-6037-1-git-send-email-schakrabarti@linux.microsoft.com>
On Tue, 21 Nov 2023 05:54:37 -0800 Souradeep Chakrabarti wrote:
> Existing MANA design assigns IRQ to every CPUs, including sibling hyper-threads
> in a core. This causes multiple IRQs to work on same CPU and may reduce the network
> performance with RSS.
>
> Improve the performance by adhering the configuration for RSS, which assigns IRQ
> on HT cores.
Drivers should not have to carry 120 LoC for something as basic as
spreading IRQs. Please take a look at include/linux/topology.h and
if there's nothing that fits your needs there - add it. That way
other drivers can reuse it.
next prev parent reply other threads:[~2023-11-21 23:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 13:54 [PATCH V2 net-next] net: mana: Assigning IRQ affinity on HT cores Souradeep Chakrabarti
2023-11-21 17:37 ` Haiyang Zhang
2023-11-21 18:51 ` Michael Kelley
2023-11-21 22:51 ` kernel test robot
2023-11-21 23:48 ` Jakub Kicinski [this message]
2023-11-27 9:36 ` [EXTERNAL] " Souradeep Chakrabarti
2023-11-27 14:32 ` Zhu Yanjun
2023-11-27 18:06 ` Jakub Kicinski
2023-11-29 22:17 ` Souradeep Chakrabarti
2023-11-30 0:02 ` Jakub Kicinski
2023-11-27 19:07 ` Florian Fainelli
2023-11-29 22:24 ` Souradeep Chakrabarti
2023-11-30 2:16 ` Yury Norov
2023-11-30 12:05 ` Souradeep Chakrabarti
2023-11-30 16:57 ` Yury Norov
2023-12-04 9:02 ` Souradeep Chakrabarti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121154841.7fc019c8@kernel.org \
--to=kuba@kernel.org \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulros@microsoft.com \
--cc=schakrabarti@linux.microsoft.com \
--cc=schakrabarti@microsoft.com \
--cc=sharmaajay@microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).