* [PATCH] USB: gl620a: check for rx buffer overflow
@ 2023-11-21 13:43 Oliver Neukum
2023-11-22 1:42 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2023-11-21 13:43 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, linux-usb, netdev; +Cc: Oliver Neukum
The driver checks for a single package overflowing
maximum size. That needs to be done, but it is not
enough. As a single transmission can contain a high
number of packets, we also need to check whether
the aggregate of messages in itself short enough
overflow the buffer.
That is easiest done by checking that the current
packet does not overflow the buffer.
Signed-off-ny: Oliver Neukum <oneukum@suse.com>
---
drivers/net/usb/gl620a.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/gl620a.c b/drivers/net/usb/gl620a.c
index 46af78caf457..d33ae15abdc1 100644
--- a/drivers/net/usb/gl620a.c
+++ b/drivers/net/usb/gl620a.c
@@ -104,6 +104,10 @@ static int genelink_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
return 0;
}
+ /* we also need to check for overflowing the buffer */
+ if (size > skb->len)
+ return 0;
+
// allocate the skb for the individual packet
gl_skb = alloc_skb(size, GFP_ATOMIC);
if (gl_skb) {
--
2.42.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-22 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 13:43 [PATCH] USB: gl620a: check for rx buffer overflow Oliver Neukum
2023-11-22 1:42 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).