From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Köry Maincent" <kory.maincent@bootlin.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Radu Pirea" <radu-nicolae.pirea@oss.nxp.com>,
"Jay Vosburgh" <j.vosburgh@gmail.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com, "Simon Horman" <horms@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time stamping layer be selectable
Date: Wed, 22 Nov 2023 10:01:42 -0800 [thread overview]
Message-ID: <20231122100142.338a2092@kernel.org> (raw)
In-Reply-To: <20231122165517.5cqqfor3zjqgyoow@skbuf>
On Wed, 22 Nov 2023 18:55:17 +0200 Vladimir Oltean wrote:
> > Well, ethtool has been the catch all for a lot of random things
> > for the longest time. The question is whether we want to extend
> > ETHTOOL_GET_TS_INFO or add a third API somewhere else. And if we
> > do - do we also duplicate the functionality of ETHTOOL_GET_TS_INFO
> > (i.e. getting capabilities)?
> >
> > My vote is that keeping it in ethtool is less bad than 3rd API.
>
> With SIOCSHWTSTAMP also implemented by CAN (and presumably also by
> wireless in the future), I do wonder whether ethtool is the right place
> for the netlink conversion.
ethtool currently provides the only way we have to configure ring
length, ring count, RSS, UDP tunnels etc.
It's a matter of taste, IMO ethtool is a bit of a lost cause already
and keeping things together (ethtool already has TS_INFO) is cleaner
than spreading them around.
> I wouldn't suggest duplicating ETHTOOL_GET_TS_INFO towards the netdev
> netlink family.
FTR so far the netdev family is all about SW configuration. We should
probably keep it that way, so it doesn't become ginormous. It's easy
enough to create a new family, if needed.
next prev parent reply other threads:[~2023-11-22 18:01 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 11:28 [PATCH net-next v7 00/16] net: Make timestamping selectable Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 01/16] net: Convert PHYs hwtstamp callback to use kernel_hwtstamp_config Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 02/16] net: phy: Remove the call to phy_mii_ioctl in phy_hwstamp_get/set Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 03/16] net: ethtool: Refactor identical get_ts_info implementations Köry Maincent
2023-11-14 11:28 ` [PATCH net-next v7 04/16] net: macb: Convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 05/16] net: Make dev_set_hwtstamp_phylib accessible Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 06/16] net: phy: micrel: fix ts_info value in case of no phc Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 07/16] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Kory Maincent
2023-11-14 15:52 ` Willem de Bruijn
2023-11-19 2:22 ` Jakub Kicinski
2023-11-20 9:05 ` Köry Maincent
2023-11-20 16:48 ` Jakub Kicinski
2023-11-20 16:51 ` Willem de Bruijn
2023-11-14 11:28 ` [PATCH net-next v7 08/16] net: ethtool: Add a command to expose current time stamping layer Kory Maincent
2023-11-19 2:24 ` Jakub Kicinski
2023-11-20 9:17 ` Köry Maincent
2023-11-20 10:40 ` Köry Maincent
2023-11-14 11:28 ` [PATCH net-next v7 09/16] netlink: specs: Introduce new netlink command to get current timestamp Kory Maincent
2023-11-19 2:25 ` Jakub Kicinski
2023-11-14 11:28 ` [PATCH net-next v7 10/16] net: ethtool: Add a command to list available time stamping layers Kory Maincent
2023-11-19 2:26 ` Jakub Kicinski
2023-11-14 11:28 ` [PATCH net-next v7 11/16] netlink: specs: Introduce new netlink " Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 12/16] net: Replace hwtstamp_source by timestamping layer Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 13/16] net: Change the API of PHY default timestamp to MAC Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 14/16] net: ethtool: ts: Update GET_TS to reply the current selected timestamp Kory Maincent
2023-11-14 11:28 ` [PATCH net-next v7 15/16] net: ethtool: ts: Let the active time stamping layer be selectable Kory Maincent
2023-11-19 2:34 ` Jakub Kicinski
2023-11-20 9:44 ` Köry Maincent
2023-11-20 10:52 ` Vladimir Oltean
2023-11-20 11:14 ` Köry Maincent
2023-11-20 12:06 ` Vladimir Oltean
2023-11-20 13:49 ` Köry Maincent
2023-11-20 14:23 ` Vladimir Oltean
2023-11-20 14:53 ` Köry Maincent
2023-11-20 16:10 ` Vladimir Oltean
2023-11-20 17:17 ` Köry Maincent
2023-11-20 17:37 ` Jakub Kicinski
2023-11-20 18:39 ` Andrew Lunn
2023-11-20 18:51 ` Jakub Kicinski
2023-11-20 19:58 ` Vladimir Oltean
2023-11-20 21:45 ` Jakub Kicinski
2023-11-29 20:09 ` Köry Maincent
2023-11-29 20:37 ` Vladimir Oltean
2023-11-29 22:00 ` Köry Maincent
2023-11-29 23:56 ` Jakub Kicinski
2023-11-30 0:06 ` Rahul Rameshbabu
2023-11-20 19:09 ` Russell King (Oracle)
2023-11-20 19:00 ` Vladimir Oltean
2023-11-20 19:58 ` Jakub Kicinski
2023-11-20 21:17 ` Vladimir Oltean
2023-11-20 21:37 ` Jakub Kicinski
2023-11-20 22:05 ` Vladimir Oltean
2023-11-21 17:31 ` Köry Maincent
2023-11-21 17:43 ` Jakub Kicinski
2023-11-22 13:44 ` Köry Maincent
2023-11-22 14:08 ` Vladimir Oltean
2023-11-22 14:19 ` Vladimir Oltean
2023-11-22 14:36 ` Vladimir Oltean
2023-11-22 16:54 ` Jakub Kicinski
2023-11-22 16:59 ` Vladimir Oltean
2023-11-22 17:55 ` Jakub Kicinski
2023-11-22 18:11 ` Willem de Bruijn
2023-11-24 17:27 ` Vladimir Oltean
2023-11-24 19:45 ` Willem de Bruijn
2023-11-25 19:41 ` Richard Cochran
2023-11-22 14:57 ` Köry Maincent
2023-11-22 16:50 ` Jakub Kicinski
2023-11-22 16:55 ` Vladimir Oltean
2023-11-22 18:01 ` Jakub Kicinski [this message]
2023-11-23 15:00 ` Köry Maincent
2023-11-23 17:32 ` Jakub Kicinski
2023-11-24 15:43 ` Vladimir Oltean
2023-11-24 17:34 ` Köry Maincent
2023-11-24 19:57 ` Vladimir Oltean
2023-11-24 20:47 ` Willem de Bruijn
2023-11-21 23:40 ` Richard Cochran
2023-11-14 11:28 ` [PATCH net-next v7 16/16] netlink: specs: Introduce time stamping set command Kory Maincent
2023-11-18 15:10 ` [PATCH net-next v7 00/16] net: Make timestamping selectable patchwork-bot+netdevbpf
2023-11-19 2:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122100142.338a2092@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).