From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 1/8] tcp: Clean up reverse xmas tree in cookie_v[46]_check().
Date: Wed, 22 Nov 2023 17:25:14 -0800 [thread overview]
Message-ID: <20231123012521.62841-2-kuniyu@amazon.com> (raw)
In-Reply-To: <20231123012521.62841-1-kuniyu@amazon.com>
We will grow and cut the xmas tree in cookie_v[46]_check().
This patch cleans it up to make later patches tidy.
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/ipv4/syncookies.c | 10 +++++-----
net/ipv6/syncookies.c | 12 ++++++------
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index d37282c06e3d..a0118ea76734 100644
--- a/net/ipv4/syncookies.c
+++ b/net/ipv4/syncookies.c
@@ -331,18 +331,18 @@ EXPORT_SYMBOL_GPL(cookie_tcp_reqsk_alloc);
struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb)
{
struct ip_options *opt = &TCP_SKB_CB(skb)->header.h4.opt;
+ const struct tcphdr *th = tcp_hdr(skb);
+ __u32 cookie = ntohl(th->ack_seq) - 1;
struct tcp_options_received tcp_opt;
+ struct tcp_sock *tp = tcp_sk(sk);
struct inet_request_sock *ireq;
struct tcp_request_sock *treq;
- struct tcp_sock *tp = tcp_sk(sk);
- const struct tcphdr *th = tcp_hdr(skb);
- __u32 cookie = ntohl(th->ack_seq) - 1;
- struct sock *ret = sk;
struct request_sock *req;
+ struct sock *ret = sk;
int full_space, mss;
+ struct flowi4 fl4;
struct rtable *rt;
__u8 rcv_wscale;
- struct flowi4 fl4;
u32 tsoff = 0;
int l3index;
diff --git a/net/ipv6/syncookies.c b/net/ipv6/syncookies.c
index 12eedc6ca2cc..aa5fb5486cde 100644
--- a/net/ipv6/syncookies.c
+++ b/net/ipv6/syncookies.c
@@ -127,17 +127,17 @@ EXPORT_SYMBOL_GPL(__cookie_v6_check);
struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb)
{
+ const struct tcphdr *th = tcp_hdr(skb);
+ __u32 cookie = ntohl(th->ack_seq) - 1;
+ struct ipv6_pinfo *np = inet6_sk(sk);
struct tcp_options_received tcp_opt;
+ struct tcp_sock *tp = tcp_sk(sk);
struct inet_request_sock *ireq;
struct tcp_request_sock *treq;
- struct ipv6_pinfo *np = inet6_sk(sk);
- struct tcp_sock *tp = tcp_sk(sk);
- const struct tcphdr *th = tcp_hdr(skb);
- __u32 cookie = ntohl(th->ack_seq) - 1;
- struct sock *ret = sk;
struct request_sock *req;
- int full_space, mss;
struct dst_entry *dst;
+ struct sock *ret = sk;
+ int full_space, mss;
__u8 rcv_wscale;
u32 tsoff = 0;
int l3index;
--
2.30.2
next prev parent reply other threads:[~2023-11-23 1:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 1:25 [PATCH v1 net-next 0/8] tcp: Clean up and refactor cookie_v[46]_check() Kuniyuki Iwashima
2023-11-23 1:25 ` Kuniyuki Iwashima [this message]
2023-11-24 21:44 ` [PATCH v1 net-next 1/8] tcp: Clean up reverse xmas tree in cookie_v[46]_check() Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 2/8] tcp: Cache sock_net(sk) " Kuniyuki Iwashima
2023-11-24 21:44 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 3/8] tcp: Clean up goto labels " Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 4/8] tcp: Don't pass cookie to __cookie_v[46]_check() Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 5/8] tcp: Don't initialise tp->tsoffset in tcp_get_cookie_sock() Kuniyuki Iwashima
2023-11-24 21:45 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 6/8] tcp: Move TCP-AO bits from cookie_v[46]_check() to tcp_ao_syncookie() Kuniyuki Iwashima
2023-11-24 21:46 ` Simon Horman
2023-11-23 1:25 ` [PATCH v1 net-next 7/8] tcp: Factorise cookie-independent fields initialisation in cookie_v[46]_check() Kuniyuki Iwashima
2023-11-24 21:44 ` Simon Horman
2023-11-25 1:04 ` Kuniyuki Iwashima
2023-11-23 1:25 ` [PATCH v1 net-next 8/8] tcp: Factorise cookie-dependent " Kuniyuki Iwashima
2023-11-24 21:46 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123012521.62841-2-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).