* [PATCH net-next] mlxsw: pci: Fix missing error checking
@ 2023-11-23 12:01 Petr Machata
2023-11-23 14:38 ` Simon Horman
2023-11-25 19:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Petr Machata @ 2023-11-23 12:01 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
Cc: Ido Schimmel, Petr Machata, Simon Horman, mlxsw, Coverity Scan,
Jiri Pirko
From: Ido Schimmel <idosch@nvidia.com>
I accidentally removed the error checking after issuing the reset.
Restore it.
Fixes: f257c73e5356 ("mlxsw: pci: Add support for new reset flow")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlxsw/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/pci.c b/drivers/net/ethernet/mellanox/mlxsw/pci.c
index 0d58f13a7c7d..af99bf17eb36 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/pci.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/pci.c
@@ -1561,6 +1561,8 @@ mlxsw_pci_reset(struct mlxsw_pci *mlxsw_pci, const struct pci_device_id *id)
pci_dbg(pdev, "Starting software reset flow\n");
err = mlxsw_pci_reset_sw(mlxsw_pci);
}
+ if (err)
+ return err;
err = mlxsw_pci_sys_ready_wait(mlxsw_pci, id, &sys_status);
if (err) {
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: pci: Fix missing error checking
2023-11-23 12:01 [PATCH net-next] mlxsw: pci: Fix missing error checking Petr Machata
@ 2023-11-23 14:38 ` Simon Horman
2023-11-25 19:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-11-23 14:38 UTC (permalink / raw)
To: Petr Machata
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, Ido Schimmel, mlxsw, Coverity Scan, Jiri Pirko
On Thu, Nov 23, 2023 at 01:01:35PM +0100, Petr Machata wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> I accidentally removed the error checking after issuing the reset.
> Restore it.
>
> Fixes: f257c73e5356 ("mlxsw: pci: Add support for new reset flow")
> Reported-by: Coverity Scan <scan-admin@coverity.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: pci: Fix missing error checking
2023-11-23 12:01 [PATCH net-next] mlxsw: pci: Fix missing error checking Petr Machata
2023-11-23 14:38 ` Simon Horman
@ 2023-11-25 19:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-25 19:30 UTC (permalink / raw)
To: Petr Machata
Cc: davem, edumazet, kuba, pabeni, netdev, idosch, horms, mlxsw,
scan-admin, jiri
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 23 Nov 2023 13:01:35 +0100 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> I accidentally removed the error checking after issuing the reset.
> Restore it.
>
> Fixes: f257c73e5356 ("mlxsw: pci: Add support for new reset flow")
> Reported-by: Coverity Scan <scan-admin@coverity.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
>
> [...]
Here is the summary with links:
- [net-next] mlxsw: pci: Fix missing error checking
https://git.kernel.org/netdev/net-next/c/9f1f6111fd5d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-25 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 12:01 [PATCH net-next] mlxsw: pci: Fix missing error checking Petr Machata
2023-11-23 14:38 ` Simon Horman
2023-11-25 19:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).