From: Kent Overstreet <kent.overstreet@linux.dev>
To: netdev@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: [PATCH] rhashtable: Better error message on allocation failure
Date: Thu, 23 Nov 2023 18:59:49 -0500 [thread overview]
Message-ID: <20231123235949.421106-1-kent.overstreet@linux.dev> (raw)
Memory allocation failures print backtraces by default, but when we're
running out of a rhashtable worker the backtrace is useless - it doesn't
tell us which hashtable the allocation failure was for.
This adds a dedicated warning that prints out functions from the
rhashtable params, which will be a bit more useful.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Thomas Graf <tgraf@suug.ch>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
---
lib/rhashtable.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index 6ae2ba8e06a2..d3fce9c8989a 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -360,9 +360,14 @@ static int rhashtable_rehash_alloc(struct rhashtable *ht,
ASSERT_RHT_MUTEX(ht);
- new_tbl = bucket_table_alloc(ht, size, GFP_KERNEL);
- if (new_tbl == NULL)
+ new_tbl = bucket_table_alloc(ht, size, GFP_KERNEL|__GFP_NOWARN);
+ if (new_tbl == NULL) {
+ WARN("rhashtable bucket table allocation failure for %ps",
+ (void *) ht->p.hashfn ?:
+ (void *) ht->p.obj_hashfn ?:
+ (void *) ht->p.obj_cmpfn);
return -ENOMEM;
+ }
err = rhashtable_rehash_attach(ht, old_tbl, new_tbl);
if (err)
--
2.42.0
next reply other threads:[~2023-11-23 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 23:59 Kent Overstreet [this message]
2023-11-25 15:23 ` [PATCH] rhashtable: Better error message on allocation failure David Laight
2023-11-29 1:35 ` Jakub Kicinski
2023-11-29 1:57 ` Kent Overstreet
2023-11-29 2:15 ` Jakub Kicinski
2023-11-29 9:20 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123235949.421106-1-kent.overstreet@linux.dev \
--to=kent.overstreet@linux.dev \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).