From: Simon Horman <horms@kernel.org>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Marcin Szycik <marcin.szycik@linux.intel.com>
Subject: Re: [PATCH iwl-next v1 07/13] ice: fix pre-shifted bit usage
Date: Fri, 24 Nov 2023 11:00:57 +0000 [thread overview]
Message-ID: <20231124110057.GG50352@kernel.org> (raw)
In-Reply-To: <20231121211921.19834-8-jesse.brandeburg@intel.com>
On Tue, Nov 21, 2023 at 01:19:15PM -0800, Jesse Brandeburg wrote:
> While converting to FIELD_PREP() and FIELD_GET(), it was noticed that
> some of the RSS defines had *included* the shift in their definitions.
> This is completely outside of normal, such that a developer could easily
> make a mistake and shift at the usage site (like when using
> FIELD_PREP()).
>
> Rename the defines and set them to the "pre-shifted values" so they
> match the template the driver normally uses for masks and the member
> bits of the mask, which also allows the driver to use FIELD_PREP
> correctly with these values. Use GENMASK() for this changed MASK value.
>
> Do the same for the VLAN EMODE defines as well.
>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-11-24 11:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 21:19 [PATCH iwl-next v1 00/13] intel: use FIELD_PREP and FIELD_GET Jesse Brandeburg
2023-11-21 21:19 ` [PATCH iwl-next v1 01/13] e1000e: make lost bits explicit Jesse Brandeburg
2023-11-24 10:59 ` Simon Horman
2023-11-21 21:19 ` [PATCH iwl-next v1 02/13] intel: add bit macro includes where needed Jesse Brandeburg
2023-11-24 10:59 ` Simon Horman
2023-11-21 21:19 ` [PATCH iwl-next v1 03/13] intel: legacy: field prep conversion Jesse Brandeburg
2023-11-24 10:59 ` Simon Horman
2023-12-05 6:15 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [PATCH iwl-next v1 04/13] i40e: " Jesse Brandeburg
2023-11-24 11:00 ` Simon Horman
2023-11-21 21:19 ` [PATCH iwl-next v1 05/13] iavf: " Jesse Brandeburg
2023-11-24 11:00 ` Simon Horman
2023-11-21 21:19 ` [PATCH iwl-next v1 06/13] ice: " Jesse Brandeburg
2023-11-24 11:00 ` Simon Horman
2023-12-05 6:29 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [PATCH iwl-next v1 07/13] ice: fix pre-shifted bit usage Jesse Brandeburg
2023-11-24 11:00 ` Simon Horman [this message]
2023-11-21 21:19 ` [PATCH iwl-next v1 08/13] igc: field prep conversion Jesse Brandeburg
2023-11-24 11:01 ` Simon Horman
2023-12-05 11:16 ` [Intel-wired-lan] " naamax.meir
2023-11-21 21:19 ` [PATCH iwl-next v1 09/13] intel: legacy: field get conversion Jesse Brandeburg
2023-11-24 11:01 ` Simon Horman
2023-12-05 6:33 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [PATCH iwl-next v1 10/13] igc: " Jesse Brandeburg
2023-11-24 11:01 ` Simon Horman
2023-12-06 8:22 ` [Intel-wired-lan] " naamax.meir
2023-11-21 21:19 ` [PATCH iwl-next v1 11/13] i40e: " Jesse Brandeburg
2023-11-24 11:02 ` Simon Horman
2023-11-27 8:38 ` Loktionov, Aleksandr
2023-12-05 6:38 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2023-11-21 21:19 ` [PATCH iwl-next v1 12/13] iavf: " Jesse Brandeburg
2023-11-24 11:02 ` Simon Horman
2023-11-21 21:19 ` [PATCH iwl-next v1 13/13] ice: " Jesse Brandeburg
2023-11-24 11:03 ` Simon Horman
2023-11-29 22:31 ` Jesse Brandeburg
2023-11-30 16:26 ` Simon Horman
2023-12-05 6:41 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124110057.GG50352@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).