From: Simon Horman <horms@kernel.org>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] firmware_loader: Expand Firmware upload error codes with firmware invalid error
Date: Fri, 24 Nov 2023 16:44:45 +0000 [thread overview]
Message-ID: <20231124164445.GS50352@kernel.org> (raw)
In-Reply-To: <20231122114325.5bacca5a@kmaincent-XPS-13-7390>
On Wed, Nov 22, 2023 at 11:43:25AM +0100, Köry Maincent wrote:
> On Tue, 21 Nov 2023 17:30:22 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
>
> > On Tue, 21 Nov 2023 11:50:35 +0100 Kory Maincent wrote:
> > > No error code are available to signal an invalid firmware content.
> > > Drivers that can check the firmware content validity can not return this
> > > specific failure to the user-space
> > >
> > > Expand the firmware error code with an additional code:
> > > - "firmware invalid" code which can be used when the provided firmware
> > > is invalid
> >
> > Any idea what this is?
> >
> > lib/test_firmware.o: warning: objtool: test_fw_upload_prepare() falls through
> > to next function __cfi_test_fw_upload_cancel()
> >
> > My build shows this on an incremental clang 17 build.
>
> For my curiosity, how do you get this error?
>
> Enabling test_firmware and building with W=1 does not show the error.
Hi Kory,
I am able to observe this warning when compiling with clang-16
make LLVM=1 lib/test_firmware.o
...
prev parent reply other threads:[~2023-11-24 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:50 [PATCH net-next v2] firmware_loader: Expand Firmware upload error codes with firmware invalid error Kory Maincent
2023-11-22 1:30 ` Jakub Kicinski
2023-11-22 9:16 ` Köry Maincent
2023-11-22 10:43 ` Köry Maincent
2023-11-24 16:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124164445.GS50352@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).