Re: [net-next RFC PATCH 04/14] net: phy: add initial support for PHY package in DT

Simon Horman
2023-11-22T10:41:43Z

On Mon, Nov 20, 2023 at 02:50:31PM +0100, Christian Marangi wrote:
> Add initial support for PHY package in DT.
>
> Make it easier to define PHY package and describe the global PHY
> directly in DT by refereincing them by phandles instead of custom
> functions in each PHY driver.
>
> Each PHY in a package needs to be defined in a dedicated node in the
> mdio node. This dedicated node needs to have the compatible set to
> "ethernet-phy-package" and define "global-phys" and "#global-phy-cells"
> respectively to a list of phandle to the global phy to define for the
> PHY package and 0 for cells as the phandle won't take any args.
>
> With this defined, the generic PHY probe will join each PHY in this
> dedicated node to the package.
>
> PHY driver MUST set the required global PHY count in
> .phy_package_global_phy_num to correctly verify that DT define the
> correct number of phandle to the required global PHY.
>
> mdio_bus.c and of_mdio.c is updated to now support and parse also
> PHY package subnote that have the compatible "phy-package".
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

...

> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index c2bb3f0b9dda..5bf90c49e5bd 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -339,6 +339,8 @@ struct mdio_bus_stats {
> * phy_package_leave().
> */
> struct phy_package_shared {
> + /* With PHY package defined in DT this points to the PHY package node */
> + struct device_node *np;
> /* addrs list pointer */
> /* note that this pointer is shared between different phydevs.
> * It is allocated and freed automatically by phy_package_join() and

Hi Christian,

a minor nit from my side: please add np to the kernel doc for
struct phy_package_shared.

> @@ -888,6 +890,8 @@ struct phy_led {
> * @flags: A bitfield defining certain other features this PHY
> * supports (like interrupts)
> * @driver_data: Static driver data
> + * @phy_package_global_phy_num: Num of the required global phy
> + * for PHY package global configuration.
> *
> * All functions are optional. If config_aneg or read_status
> * are not implemented, the phy core uses the genphy versions.

...