From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>, Edward Cree <ecree.xilinx@gmail.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<corbet@lwn.net>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<vladimir.oltean@nxp.com>, <andrew@lunn.ch>, <horms@kernel.org>,
<mkubecek@suse.cz>, <willemdebruijn.kernel@gmail.com>,
<gal@nvidia.com>, <alexander.duyck@gmail.com>,
<linux-doc@vger.kernel.org>,
Igor Bagnucki <igor.bagnucki@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops
Date: Mon, 27 Nov 2023 08:55:52 -0800 [thread overview]
Message-ID: <20231127085552.396f9375@kernel.org> (raw)
In-Reply-To: <4945c089-3817-47b2-9a02-2532995d3a46@intel.com>
On Mon, 27 Nov 2023 07:14:51 -0700 Ahmed Zaki wrote:
> > - First simplify the code by always providing a pointer to all params
> > (indir, key and func); the fact that some of them may be NULL seems
> > like a weird historic thing or a premature optimization.
> > It will simplify the drivers if all pointers are always present.
> > You don't have to remove the if () checks in the existing drivers.
> >
> > - Then make the functions take a dev pointer, and a pointer to a
> > single struct wrapping all arguments. The set_* should also take
> > an extack.
>
> Can we skip the "extack" part for this series? There is no
> "ETHTOOL_MSG_RSS_SET" netlink message, which is needed for user-space to
> get the ACK and adding all the netlink stuff seems a bit out of scope.
Fair point, yes, that's fine.
BTW, Ed, this series will conflict with your RSS context rework.
Not sure if it is on your radar.
next prev parent reply other threads:[~2023-11-27 16:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 20:56 [PATCH net-next v6 0/7] Support symmetric-xor RSS hash Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops Ahmed Zaki
2023-11-21 23:29 ` Jakub Kicinski
2023-11-27 14:14 ` Ahmed Zaki
2023-11-27 16:55 ` Jakub Kicinski [this message]
2023-11-27 17:10 ` Edward Cree
2023-11-27 18:04 ` Jakub Kicinski
2024-06-03 18:54 ` Edward Cree
2024-06-03 23:17 ` Jakub Kicinski
2024-06-04 14:58 ` Edward Cree
2024-06-04 17:33 ` Jakub Kicinski
2023-11-28 20:19 ` Keller, Jacob E
2024-06-05 17:42 ` Gal Pressman
2024-06-05 17:56 ` Ahmed Zaki
2024-06-05 18:27 ` Keller, Jacob E
2023-11-20 20:56 ` [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash Ahmed Zaki
2023-11-21 23:33 ` Jakub Kicinski
2023-11-23 13:33 ` Gal Pressman
2023-11-23 16:27 ` Jakub Kicinski
2023-11-27 14:21 ` Ahmed Zaki
2023-11-27 16:57 ` Jakub Kicinski
2023-11-20 20:56 ` [PATCH net-next v6 3/7] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 4/7] ice: refactor RSS configuration Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 5/7] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 6/7] ice: enable symmetric-xor RSS for Toeplitz hash function Ahmed Zaki
2023-11-20 20:56 ` [PATCH net-next v6 7/7] iavf: " Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127085552.396f9375@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).